Source/core/dom/Element.cpp - Issue 273783003: Don't schedule invalidations when attributes changed if not needed or incorrect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 273783003: Don't schedule invalidations when attributes changed if not needed or incorrect. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add some styleChangeType() < SubtreeStyleChange checks in ContainerNode. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 1997e9d06bbfe6c070e576ec7ed8cd2d48d31677..c19f22870d364f717767a9dbcc67b0d3911e9c03 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2801,7 +2801,7 @@ void Element::willModifyAttribute(const QualifiedName& name, const AtomicString&

}

if (oldValue != newValue) {

- if (inActiveDocument())

+ if (inActiveDocument() && document().styleResolver() && styleChangeType() < SubtreeStyleChange)

ojan 2014/05/08 19:14:56 We chatted about this in person. I'm not sure the

esprehn 2014/05/08 19:17:56 Yeah it doesn't seem like we do that anymore, want

document().ensureStyleResolver().ensureUpdatedRuleFeatureSet().scheduleStyleInvalidationForAttributeChange(name, *this);

if (isUpgradedCustomElement())

« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »