Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2737743003: [Reading List] Expand all Wikipedia sections on distillation. (Closed)

Created:
3 years, 9 months ago by Olivier
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Reading List] Expand all Wikipedia sections on distillation. Most part of Wikipedia articles is hidden when the page loads. DOM distiller will eventually handle this issue, but for the time being, this is a workaround. The workaround set the style to block before distilling the page. BUG=647667, 699215 Review-Url: https://codereview.chromium.org/2730863002 Cr-Commit-Position: refs/heads/master@{#455186} (cherry picked from commit f2b4f5683185e5bfdc90c42f97d49ed3e06ca1f2) Review-Url: https://codereview.chromium.org/2737743003 . Cr-Commit-Position: refs/branch-heads/3029@{#59} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M ios/chrome/browser/reading_list/reading_list_distiller_page.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 4 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 9 months ago (2017-03-08 08:32:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ff6fa0d932afd0d27a11f4bd1de9b04586b35b8.

Powered by Google App Engine
This is Rietveld 408576698