Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2737743002: Make idle tasks optional in the default platform. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make idle tasks optional in the default platform. BUG=v8:6056 Review-Url: https://codereview.chromium.org/2737743002 Cr-Commit-Position: refs/heads/master@{#43640} Committed: https://chromium.googlesource.com/v8/v8/+/dab18fb0bbcddfc2468abf41ffdb83a53305838a

Patch Set 1 #

Patch Set 2 : remove leftover #

Patch Set 3 : fix tests #

Patch Set 4 : another fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M include/libplatform/libplatform.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/d8.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/libplatform/default-platform.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 1 2 4 chunks +11 lines, -6 lines 0 comments Download
M test/unittests/libplatform/default-platform-unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/run-all-unittests.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
ptal
3 years, 9 months ago (2017-03-07 12:22:31 UTC) #2
jochen (gone - plz use gerrit)
somewhat surprised that the default-platform-unittests don't fail?
3 years, 9 months ago (2017-03-07 12:24:31 UTC) #3
ulan
On 2017/03/07 12:24:31, jochen wrote: > somewhat surprised that the default-platform-unittests don't fail? Fixed, ptal.
3 years, 9 months ago (2017-03-07 13:10:07 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-07 13:11:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737743002/60001
3 years, 9 months ago (2017-03-07 13:12:47 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 13:37:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/dab18fb0bbcddfc2468abf41ffdb83a5330...

Powered by Google App Engine
This is Rietveld 408576698