Add Active Directory login UI tests

chrome/browser/chromeos/login/helper.h

Index: chrome/browser/chromeos/login/helper.h
diff --git a/chrome/browser/chromeos/login/helper.h b/chrome/browser/chromeos/login/helper.h
index cd27dc773f406c356b6cb5c9acee4a50aa2882fd..100e95041fe7aa9f39d079420c57fbbd1894444a 100644
--- a/chrome/browser/chromeos/login/helper.h
+++ b/chrome/browser/chromeos/login/helper.h
@@ -42,6 +42,16 @@ int GetCurrentUserImageSize();
 // conflict with other chromeos components.
 namespace login {
 
+// Possible error states of the Active Directory screen. Must be in the same
+// order as ACTIVE_DIRECTORY_ERROR_STATE enum values.
+enum ActiveDirectoryErrorState {

[achuithb, 2017/03/07 15:07:03]

Can you make this an enum class since you're touching/moving this?

Also, is there a better place to put this? We don't want login/helper.h to be a
dumping ground for random unrelated things.

[Roman Sorokin (ftl), 2017/03/07 15:18:20]

I'm not sure, it's needed in both enrollment_screen_handler.cc and
gaia_screen_handler.cc. Should I create a new *.h file?

[achuithb, 2017/03/07 15:28:50]

How about moving it to enrollment_screen_handler.h?

[Roman Sorokin (ftl), 2017/03/07 16:32:05]

That way gaia_screen_handler.cc does not see it

[achuithb, 2017/03/09 10:34:06]

Why not include enrollment_screen_handler.h in gaia_screen_handler.cc? Including
some extra stuff in a cc file shouldn't be a big problem.

[Roman Sorokin (ftl), 2017/03/22 15:19:25]

Done.

+  ERROR_STATE_NONE = 0,
+  ERROR_STATE_MACHINE_NAME_INVALID = 1,
+  ERROR_STATE_MACHINE_NAME_TOO_LONG = 2,
+  ERROR_STATE_BAD_USERNAME = 3,
+  ERROR_STATE_BAD_PASSWORD = 4,
+};
+
 // Maximum size of user image, in which it should be saved to be properly
 // displayed under all possible DPI values.
 const int kMaxUserImageSize = 512;