Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2737733002: Fix crash in FontFaceSet::ready (Closed)

Created:
3 years, 9 months ago by Kunihiko Sakamoto
Modified:
3 years, 9 months ago
Reviewers:
kojii
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, drott
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in FontFaceSet::ready This fixes a crash introduced by http://crrev.com/2722493002. FontFaceSet can outlive Document, so aliveness check is needed before touching the document. BUG=698776 Review-Url: https://codereview.chromium.org/2737733002 Cr-Commit-Position: refs/heads/master@{#455349} Committed: https://chromium.googlesource.com/chromium/src/+/ac3c0012ce426716061dc073928f701fd64ff712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Kunihiko Sakamoto
3 years, 9 months ago (2017-03-07 06:26:34 UTC) #7
kojii
lgtm, thank you for taking an immediate action!
3 years, 9 months ago (2017-03-07 13:30:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737733002/20001
3 years, 9 months ago (2017-03-08 00:29:27 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 02:21:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac3c0012ce426716061dc073928f...

Powered by Google App Engine
This is Rietveld 408576698