chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java - Issue 2737723002: Downloads : Last access time update for NTP, duplicate infobar and notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Issue 2737723002: Downloads : Last access time update for NTP, duplicate infobar and notifications (Closed)

Patch Set: Removed changes for duplicate infobar Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java » ('j') | components/ntp_snippets/content_suggestion.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

index a41d5a4616568a7e2ccfbf39365b93a5e7c9e941..7775861726e0b9ce43de73088e3d22114d94357e 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

@@ -289,7 +289,8 @@ public class DownloadNotificationServiceTest extends

sharedPrefs, DownloadSharedPreferenceHelper.KEY_PENDING_DOWNLOAD_NOTIFICATIONS);

assertEquals(3, entries.size());

- service.notifyDownloadSuccessful(guid1, "/path/to/success", "success", 100L, false, false);

+ service.notifyDownloadSuccessful(

+ guid1, "/path/to/success", "success", 100L, false, false, false);

entries = DownloadManagerService.getStoredDownloadInfo(

sharedPrefs, DownloadSharedPreferenceHelper.KEY_PENDING_DOWNLOAD_NOTIFICATIONS);

assertEquals(2, entries.size());

@@ -315,7 +316,7 @@ public class DownloadNotificationServiceTest extends

startNotificationService();

DownloadNotificationService service = bindNotificationService();

String guid = UUID.randomUUID().toString();

- service.notifyDownloadSuccessful(guid, "/path/to/test", "test", 100L, false, false);

+ service.notifyDownloadSuccessful(guid, "/path/to/test", "test", 100L, false, false, false);

assertEquals(1, getService().getNotificationIds().size());

}