Downloads : Last access time update for NTP, duplicate infobar and notifications

components/ntp_snippets/content_suggestion.h

Index: components/ntp_snippets/content_suggestion.h
diff --git a/components/ntp_snippets/content_suggestion.h b/components/ntp_snippets/content_suggestion.h
index ea17274c45fe2402060c6c2e6830f3b42cbf9390..b2403f6c749ef97c3245abbaba77e7288dd6e952 100644
--- a/components/ntp_snippets/content_suggestion.h
+++ b/components/ntp_snippets/content_suggestion.h
@@ -21,8 +21,11 @@ namespace ntp_snippets {
 // download suggestions.
 struct DownloadSuggestionExtra {
   DownloadSuggestionExtra();
+  DownloadSuggestionExtra(const DownloadSuggestionExtra&);

[vitaliii, 2017/03/10 08:15:46]

Why do you need a copy constructor here?

[shaktisahu, 2017/03/10 08:46:55]

To make the compiler happy. It complained about something like copy constructor
needed for complex structs.

[vitaliii, 2017/03/10 09:04:38]

I am not sure what you mean. I just patched the CL and removed the copy
constructor and everything compiled fine (signed build for Android). 

I just cannot understand why adding another std::string would make the struct
complex (especially taking into account |std::string mime_type|).

[shaktisahu, 2017/03/10 15:23:01]

This error comes up during compiling download_suggestions_provider_unittest.cc
in linux. See the bot failure in patch 1 for linux_chromium_rel_ng.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...

[vitaliii, 2017/03/10 16:41:21]

ACK

   ~DownloadSuggestionExtra();
 
+  // The GUID for the downloaded file.
+  std::string download_guid;
   // The file path of the downloaded file once download completes.
   base::FilePath target_file_path;
   // The effective MIME type of downloaded content.