Rename updateWidgets to updatePlugins

Rename updateWidgets to updatePlugins

Methods associated with timer to update HTMLPlugInElement
(HTMLEmbedElement and HTMLObjectElement) have been renamed
from *updateWidget* to *updatePlugin*.

BUG=697351
Review-Url: https://codereview.chromium.org/2737713002
Cr-Commit-Position: refs/heads/master@{#455345}
Committed: https://chromium.googlesource.com/chromium/src/+/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b

[joelhockey, 2017-03-07 05:15:47]

joelhockey@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-03-07 05:17:48]

Thanks Joel! :) LGTM

Also please wrap your CL description to 72 characters :)

[joelhockey, 2017-03-07 05:41:46]

On 2017/03/07 at 05:17:48, sashab wrote:
> Thanks Joel! :) LGTM
> 
> Also please wrap your CL description to 72 characters :)

I remember now you have said about the 72 char limit before?  Do you know what
the limit is for?  Would it makes sense to have codereview UI automatically do
wrapping at that limit?

[joelhockey, 2017-03-07 05:51:15]

Description was changed from

==========
Rename updateWidgets to updatePlugins

Methods associated with timer to update HTMLPlugInElement (HTMLEmbedElement and
HTMLObjectElement) have been renamed from *updateWidget* to *updatePlugin*.

BUG=697351
==========

to

==========
Rename updateWidgets to updatePlugins

Methods associated with timer to update HTMLPlugInElement
(HTMLEmbedElement and HTMLObjectElement) have been renamed
from *updateWidget* to *updatePlugin*.

BUG=697351
==========

[joelhockey, 2017-03-07 05:51:29]

joelhockey@chromium.org changed reviewers:
+ haraken@chromium.org

[joelhockey, 2017-03-07 05:51:40]

haraken ptal

[joelhockey, 2017-03-07 05:52:32]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 05:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 06:07:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:07:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-03-07 06:32:56]

LGTM

[joelhockey, 2017-03-07 21:26:23]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-07 21:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-07 21:32:24]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-07 21:32:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2737713002/#ps40001
(title: "Rename updateWidgets to updatePlugins")

[commit-bot: I haz the power, 2017-03-07 21:34:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 23:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 23:30:08]

Failed to apply patch for third_party/WebKit/Source/core/frame/FrameView.cpp:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/FrameView.cpp:2437
  error: third_party/WebKit/Source/core/frame/FrameView.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/core/frame/FrameView.cpp
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp
b/third_party/WebKit/Source/core/frame/FrameView.cpp
index
1909121cd9c424bdd375af26ddd6f3daa3d25a7c..b9ce9b8e622598a589d6a0d6ed55488fee43850b
100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -154,9 +154,9 @@ const int kA4PortraitPageHeight = 842;
 
 using namespace HTMLNames;
 
-// The maximum number of updateWidgets iterations that should be done before
+// The maximum number of updatePlugins iterations that should be done before
 // returning.
-static const unsigned maxUpdateWidgetsIterations = 2;
+static const unsigned maxUpdatePluginsIterations = 2;
 static const double resourcePriorityUpdateDelayAfterScroll = 0.250;
 
 static bool s_initialTrackAllPaintInvalidations = false;
@@ -171,10 +171,10 @@ FrameView::FrameView(LocalFrame& frame)
           TaskRunnerHelper::get(TaskType::UnspecedTimer, &frame),
           this,
           &FrameView::postLayoutTimerFired),
-      m_updateWidgetsTimer(
+      m_updatePluginsTimer(
           TaskRunnerHelper::get(TaskType::UnspecedTimer, &frame),
           this,
-          &FrameView::updateWidgetsTimerFired),
+          &FrameView::updatePluginsTimerFired),
       m_isTransparent(false),
       m_baseBackgroundColor(Color::white),
       m_mediaType(MediaTypeNames::screen),
@@ -261,7 +261,7 @@ void FrameView::reset() {
   m_layoutCount = 0;
   m_nestedLayoutCount = 0;
   m_postLayoutTasksTimer.stop();
-  m_updateWidgetsTimer.stop();
+  m_updatePluginsTimer.stop();
   m_firstLayout = true;
   m_safeToPropagateScrollToParent = true;
   m_lastViewportSize = IntSize();
@@ -1493,7 +1493,7 @@ void FrameView::addPartToUpdate(LayoutEmbeddedObject&
object) {
   Node* node = object.node();
   ASSERT(node);
   if (isHTMLObjectElement(*node) || isHTMLEmbedElement(*node))
-    toHTMLPlugInElement(node)->setNeedsWidgetUpdate(true);
+    toHTMLPlugInElement(node)->setNeedsPluginUpdate(true);
 
   m_partUpdateSet.insert(&object);
 }
@@ -2409,9 +2409,9 @@ void FrameView::scrollToFragmentAnchor() {
       m_frame->document()->isLoadCompleted() ? nullptr : anchorNode;
 }
 
-bool FrameView::updateWidgets() {
-  // This is always called from updateWidgetsTimerFired.
-  // m_updateWidgetsTimer should only be scheduled if we have FrameViewBases to
+bool FrameView::updatePlugins() {
+  // This is always called from updatePluginsTimerFired.
+  // m_updatePluginsTimer should only be scheduled if we have FrameViewBases to
   // update. Thus I believe we can stop checking isEmpty here, and just ASSERT
   // isEmpty:
   // FIXME: This assert has been temporarily removed due to
@@ -2437,8 +2437,8 @@ bool FrameView::updateWidgets() {
     if (object.showsUnavailablePluginIndicator())
       continue;
 
-    if (element->needsWidgetUpdate())
-      element->updateWidget();
+    if (element->needsPluginUpdate())
+      element->updatePlugin();
     object.updateWidgetGeometry();
 
     // Prevent plugins from causing infinite updates of themselves.
@@ -2449,10 +2449,10 @@ bool FrameView::updateWidgets() {
   return m_partUpdateSet.isEmpty();
 }
 
-void FrameView::updateWidgetsTimerFired(TimerBase*) {
+void FrameView::updatePluginsTimerFired(TimerBase*) {
   ASSERT(!isInPerformLayout());
-  for (unsigned i = 0; i < maxUpdateWidgetsIterations; ++i) {
-    if (updateWidgets())
+  for (unsigned i = 0; i < maxUpdatePluginsIterations; ++i) {
+    if (updatePlugins())
       return;
   }
 }
@@ -2461,17 +2461,17 @@ void FrameView::flushAnyPendingPostLayoutTasks() {
   ASSERT(!isInPerformLayout());
   if (m_postLayoutTasksTimer.isActive())
     performPostLayoutTasks();
-  if (m_updateWidgetsTimer.isActive()) {
-    m_updateWidgetsTimer.stop();
-    updateWidgetsTimerFired(nullptr);
+  if (m_updatePluginsTimer.isActive()) {
+    m_updatePluginsTimer.stop();
+    updatePluginsTimerFired(nullptr);
   }
 }
 
-void FrameView::scheduleUpdateWidgetsIfNecessary() {
+void FrameView::scheduleUpdatePluginsIfNecessary() {
   ASSERT(!isInPerformLayout());
-  if (m_updateWidgetsTimer.isActive() || m_partUpdateSet.isEmpty())
+  if (m_updatePluginsTimer.isActive() || m_partUpdateSet.isEmpty())
     return;
-  m_updateWidgetsTimer.startOneShot(0, BLINK_FROM_HERE);
+  m_updatePluginsTimer.startOneShot(0, BLINK_FROM_HERE);
 }
 
 void FrameView::performPostLayoutTasks() {
@@ -2504,7 +2504,7 @@ void FrameView::performPostLayoutTasks() {
   if (layoutViewItem().isNull())
     return;
 
-  scheduleUpdateWidgetsIfNecessary();
+  scheduleUpdatePluginsIfNecessary();
 
   if (ScrollingCoordinator* scrollingCoordinator =
this->scrollingCoordinator())
     scrollingCoordinator->notifyGeometryChanged();

[joelhockey, 2017-03-07 23:49:54]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-07 23:49:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2737713002/#ps60001
(title: "Rename updateWidgets to updatePlugins")

[commit-bot: I haz the power, 2017-03-07 23:50:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-03-08 00:39:34]

Umm I've forgotten what it's for, but it's the message you get when you upload a
patch lol. Yes it would be great if the UI did it automatically! :D

[joelhockey, 2017-03-08 01:51:17]

The CQ bit was unchecked by joelhockey@chromium.org

[joelhockey, 2017-03-08 01:51:21]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:52:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:13:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488937881160280,
"parent_rev": "2483390c3c56d62a8d65bb3bb3672102a4956505", "commit_rev":
"05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b"}

[commit-bot: I haz the power, 2017-03-08 02:13:46]

Description was changed from

==========
Rename updateWidgets to updatePlugins

Methods associated with timer to update HTMLPlugInElement
(HTMLEmbedElement and HTMLObjectElement) have been renamed
from *updateWidget* to *updatePlugin*.

BUG=697351
==========

to

==========
Rename updateWidgets to updatePlugins

Methods associated with timer to update HTMLPlugInElement
(HTMLEmbedElement and HTMLObjectElement) have been renamed
from *updateWidget* to *updatePlugin*.

BUG=697351

Review-Url: https://codereview.chromium.org/2737713002
Cr-Commit-Position: refs/heads/master@{#455345}
Committed:
https://chromium.googlesource.com/chromium/src/+/05de2f6bfbe4b0628f2a2bfbea7b...
==========

[commit-bot: I haz the power, 2017-03-08 02:13:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/05de2f6bfbe4b0628f2a2bfbea7b...