Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2737693003: Add move constructors and assignment operators to GURL (Closed)

Created:
3 years, 9 months ago by sclittle
Modified:
3 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add move constructors and assignment operators to GURL This CL implements a cheap move constructor and assignment operator for GURL, so that code that moves around GURLs a lot (e.g. an std::vector<GURL>) doesn't need to perform so many copies. BUG=698978 Review-Url: https://codereview.chromium.org/2737693003 Cr-Commit-Position: refs/heads/master@{#456828} Committed: https://chromium.googlesource.com/chromium/src/+/376085b3685d5cd6195909462036343d11fca018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M url/gurl.h View 2 chunks +3 lines, -1 line 0 comments Download
M url/gurl.cc View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sclittle
3 years, 9 months ago (2017-03-07 03:41:25 UTC) #2
brettw
I thought we already had these! LGTM
3 years, 9 months ago (2017-03-14 19:38:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737693003/1
3 years, 9 months ago (2017-03-14 19:43:31 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 21:09:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/376085b3685d5cd6195909462036...

Powered by Google App Engine
This is Rietveld 408576698