Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2737653007: Allow saving reference file as a float32 WAV file (Closed)

Created:
3 years, 9 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow saving reference file as a float32 WAV file Update the osccilator sweep tests to save the reference file as a 32-bit float WAV result and also update the expected result with this new file. The test thresholds are also updated with tighter values, and we no longer have to deal with the 16-bit aspect of the original reference files. BUG=697525 TEST=osc-custom-sweep-snr.html, osc-sawtooth-sweep-snr.html, osc-sine-sweep-snr.html, osc-square-sweep-snr.html, osc-triangle-sweep-snr.html Review-Url: https://codereview.chromium.org/2737653007 Cr-Commit-Position: refs/heads/master@{#455825} Committed: https://chromium.googlesource.com/chromium/src/+/a0075e99d4cb2cc1e27b396f574f314632a493be

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-custom-expected.wav View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-sawtooth-expected.wav View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-sine-expected.wav View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-square-expected.wav View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-triangle-expected.wav View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js View 5 chunks +47 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js View 1 6 chunks +21 lines, -37 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 9 months ago (2017-03-08 23:53:14 UTC) #3
hongchan
lgtm with nit https://codereview.chromium.org/2737653007/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js (right): https://codereview.chromium.org/2737653007/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js#newcode107 third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js:107: */ Remove the commented-out section. https://codereview.chromium.org/2737653007/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js#newcode108 ...
3 years, 9 months ago (2017-03-09 18:00:13 UTC) #4
Raymond Toy
https://codereview.chromium.org/2737653007/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js (right): https://codereview.chromium.org/2737653007/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js#newcode107 third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js:107: */ On 2017/03/09 18:00:13, hongchan wrote: > Remove the ...
3 years, 9 months ago (2017-03-09 18:09:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737653007/20001
3 years, 9 months ago (2017-03-09 18:10:54 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 19:22:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a0075e99d4cb2cc1e27b396f574f...

Powered by Google App Engine
This is Rietveld 408576698