Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2737653005: Rename OffscreenCanvasSurfaceManager to OffscreenCanvasCompositorFrameSinkManager (Closed)

Created:
3 years, 9 months ago by xing.xu
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OffscreenCanvasSurfaceManager to OffscreenCanvasCompositorFrameSinkManager This is split from fady's cl: https://codereview.chromium.org/2688593002/ BUG=686861, 664547 Review-Url: https://codereview.chromium.org/2737653005 Cr-Commit-Position: refs/heads/master@{#455638} Committed: https://chromium.googlesource.com/chromium/src/+/393f14ef1be75d165055ac0e1d26f00df44ea53b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Format header #

Messages

Total messages: 26 (15 generated)
xing.xu
PTAL.
3 years, 9 months ago (2017-03-08 07:58:53 UTC) #8
Fady Samuel
LGTM. I definitely feel this is a better name. In the slightly longer term, this ...
3 years, 9 months ago (2017-03-08 12:11:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737653005/1
3 years, 9 months ago (2017-03-08 15:22:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/380933)
3 years, 9 months ago (2017-03-08 15:30:22 UTC) #13
xlai (Olivia)
lgtm with nits. https://codereview.chromium.org/2737653005/diff/1/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc File content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc (right): https://codereview.chromium.org/2737653005/diff/1/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc#newcode5 content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc:5: #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager.h" I really wonder this ...
3 years, 9 months ago (2017-03-08 16:29:56 UTC) #14
boliu
gn rs lgtm https://codereview.chromium.org/2737653005/diff/1/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc File content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc (right): https://codereview.chromium.org/2737653005/diff/1/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc#newcode5 content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc:5: #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager.h" On 2017/03/08 16:29:56, xlai ...
3 years, 9 months ago (2017-03-08 17:00:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737653005/20001
3 years, 9 months ago (2017-03-08 22:38:16 UTC) #18
xing.xu
On 2017/03/08 17:00:58, boliu wrote: > gn rs lgtm > > https://codereview.chromium.org/2737653005/diff/1/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc > File > ...
3 years, 9 months ago (2017-03-08 22:42:25 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/397452)
3 years, 9 months ago (2017-03-09 00:42:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737653005/20001
3 years, 9 months ago (2017-03-09 00:53:14 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 02:06:11 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/393f14ef1be75d165055ac0e1d26...

Powered by Google App Engine
This is Rietveld 408576698