Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2737653003: W3CImportExpectations: Un-skip wpt/orientation-event. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3CImportExpectations: Un-skip wpt/orientation-event. Now that the DeviceMotionEvent and DeviceOrientationEvent constructors are implemented the majority of these tests should pass. BUG=651767 Review-Url: https://codereview.chromium.org/2737653003 Cr-Commit-Position: refs/heads/master@{#455294} Committed: https://chromium.googlesource.com/chromium/src/+/fec2991e99c468610b90b26f1aa017cfe2834af8

Patch Set 1 #

Patch Set 2 : Add OWNERS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 9 months ago (2017-03-07 01:37:38 UTC) #2
Reilly Grant (use Gerrit)
Add OWNERS.
3 years, 9 months ago (2017-03-07 01:48:42 UTC) #6
Reilly Grant (use Gerrit)
Sorry, I didn't read Rick's instructions carefully enough the first time. Instead of removing the ...
3 years, 9 months ago (2017-03-07 01:50:01 UTC) #7
Reilly Grant (use Gerrit)
Sorry, I didn't read Rick's instructions carefully enough the first time. Instead of removing the ...
3 years, 9 months ago (2017-03-07 01:50:02 UTC) #8
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-07 01:53:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737653003/20001
3 years, 9 months ago (2017-03-07 22:01:05 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:49:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fec2991e99c468610b90b26f1aa0...

Powered by Google App Engine
This is Rietveld 408576698