Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2737643002: Use internals.setMarker in layout tests in paint/spellmarkers/ (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use internals.setMarker in layout tests in paint/spellmarkers/ This patch removes the dependency of layout tests in paint/spellmarkers/ on the implementation of Blink's spell checker, by making them add markers directly with internals.setMarker(). As a result, they are no longer affected by spell checker rearchitecturing (e.g., idle time spell checker). BUG=698883 Review-Url: https://codereview.chromium.org/2737643002 Cr-Commit-Position: refs/heads/master@{#455073} Committed: https://chromium.googlesource.com/chromium/src/+/e58d543442b2f3049b0bd22f2a537c05cbed6a2a

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-03-07 00:02:26 UTC) #4
Stephen Chennney
Thanks for making my tests more direct. lgtm
3 years, 9 months ago (2017-03-07 14:46:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737643002/1
3 years, 9 months ago (2017-03-07 14:47:34 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 14:55:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e58d543442b2f3049b0bd22f2a53...

Powered by Google App Engine
This is Rietveld 408576698