Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2737613002:
Fixup stale freetype .gitignore entries. (Closed)
|
Created:
3 years, 9 months ago by DaleCurtis Modified:
3 years, 9 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixup stale freetype .gitignore entries.
Without this the tree is marked as dirty.
BUG=697015
Review-Url: https://codereview.chromium.org/2737613002
Cr-Commit-Position: refs/heads/master@{#454942}
Committed: https://chromium.googlesource.com/chromium/src/+/84d67b491f426b51a8d19411d313738d0aa9e240
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
dalecurtis@chromium.org changed reviewers: + thakis@chromium.org
dalecurtis@chromium.org changed reviewers: + drott@chromium.org
+drott who made the change here.
Description was changed from ========== Fixup stale freetype .gitignore entries. Without this the tree is marked as dirty. ========== to ========== Fixup stale freetype .gitignore entries. Without this the tree is marked as dirty. BUG=697015 ==========
The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Hooray for having only one freetype!
The CQ bit was unchecked by dalecurtis@chromium.org
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488831882822790, "parent_rev":
"1f6307adb1b1ff13661af0432d735866f2531831", "commit_rev":
"84d67b491f426b51a8d19411d313738d0aa9e240"}
Message was sent while issue was closed.
Description was changed from ========== Fixup stale freetype .gitignore entries. Without this the tree is marked as dirty. BUG=697015 ========== to ========== Fixup stale freetype .gitignore entries. Without this the tree is marked as dirty. BUG=697015 Review-Url: https://codereview.chromium.org/2737613002 Cr-Commit-Position: refs/heads/master@{#454942} Committed: https://chromium.googlesource.com/chromium/src/+/84d67b491f426b51a8d19411d313... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/84d67b491f426b51a8d19411d313...
Message was sent while issue was closed.
dmazzoni@chromium.org changed reviewers: + dmazzoni@chromium.org, elichtenberg@google.com
Message was sent while issue was closed.
What about third_party/freetype2 and third_party/freetype-android? git status lists those, should they be in .gitignore too?
Message was sent while issue was closed.
On 2017/03/10 at 21:27:08, dmazzoni wrote: > What about third_party/freetype2 and > third_party/freetype-android? > > git status lists those, should they be in .gitignore too? I think you should delete those, they're old. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
