Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2737603006: [inspector] added createContextGroup for tests (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added createContextGroup for tests BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2737603006 Cr-Commit-Position: refs/heads/master@{#43657} Committed: https://chromium.googlesource.com/v8/v8/+/e502665d34c43635e63f62084b2798e2fb02c7de

Patch Set 1 #

Total comments: 2

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -37 lines) Patch
M test/inspector/inspector-impl.h View 1 2 chunks +11 lines, -5 lines 0 comments Download
M test/inspector/inspector-impl.cc View 8 chunks +101 lines, -18 lines 0 comments Download
M test/inspector/inspector-test.cc View 4 chunks +29 lines, -1 line 0 comments Download
M test/inspector/protocol-test.js View 4 chunks +7 lines, -5 lines 0 comments Download
A test/inspector/runtime/create-context.js View 1 chunk +42 lines, -0 lines 0 comments Download
A test/inspector/runtime/create-context-expected.txt View 1 chunk +58 lines, -0 lines 0 comments Download
M test/inspector/task-runner.h View 3 chunks +7 lines, -2 lines 0 comments Download
M test/inspector/task-runner.cc View 5 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kozy
Dmitry, please take a look!
3 years, 9 months ago (2017-03-07 20:13:33 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2737603006/diff/1/test/inspector/inspector-impl.h File test/inspector/inspector-impl.h (right): https://codereview.chromium.org/2737603006/diff/1/test/inspector/inspector-impl.h#newcode38 test/inspector/inspector-impl.h:38: v8_inspector::V8InspectorSession* session(int context_group_id = 0); Note that inspector ...
3 years, 9 months ago (2017-03-07 21:47:14 UTC) #2
kozy
https://codereview.chromium.org/2737603006/diff/1/test/inspector/inspector-impl.h File test/inspector/inspector-impl.h (right): https://codereview.chromium.org/2737603006/diff/1/test/inspector/inspector-impl.h#newcode38 test/inspector/inspector-impl.h:38: v8_inspector::V8InspectorSession* session(int context_group_id = 0); On 2017/03/07 21:47:14, dgozman ...
3 years, 9 months ago (2017-03-07 22:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737603006/20001
3 years, 9 months ago (2017-03-07 22:06:24 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:30:12 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e502665d34c43635e63f62084b2798e2fb0...

Powered by Google App Engine
This is Rietveld 408576698