Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2737583002: Gate pinning on |GOOGLE_CHROME_BUILD|. (Closed)

Created:
3 years, 9 months ago by agl
Modified:
3 years, 9 months ago
Reviewers:
lgarron
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gate pinning on |GOOGLE_CHROME_BUILD|. Reportedly[1], |OFFICIAL_BUILD| no longer means what the name suggests and |GOOGLE_CHROME_BUILD| is the correct define to use. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/4F5hM8XMOhQ BUG=none Review-Url: https://codereview.chromium.org/2737583002 Cr-Commit-Position: refs/heads/master@{#455205} Committed: https://chromium.googlesource.com/chromium/src/+/90eff08ec4227af957ea58ff1a70e870520be9d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/http/transport_security_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
agl
3 years, 9 months ago (2017-03-06 17:00:00 UTC) #2
lgarron
As far as I understand, we gate on GOOGLE_CHROME_BUILD because those are the builds we ...
3 years, 9 months ago (2017-03-06 23:48:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737583002/1
3 years, 9 months ago (2017-03-06 23:52:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395167)
3 years, 9 months ago (2017-03-07 02:57:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737583002/1
3 years, 9 months ago (2017-03-07 18:43:51 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:46:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90eff08ec4227af957ea58ff1a70...

Powered by Google App Engine
This is Rietveld 408576698