chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc - Issue 2737563007: Add support for tracking loading behavior of child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)

Patch Set: improve test comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc ('K') | « chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc ('k') | chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

index b2e041f94b915e644bbe5ac495db7b5fd1f89541..117e0b09e507ee59b5beea7e73fc452f990f92d3 100644

--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

@@ -57,6 +57,7 @@ class TestMetricsRenderFrameObserver : public MetricsRenderFrameObserver {

bool ShouldSendMetrics() const override { return true; }

bool HasNoRenderFrame() const override { return false; }

+ bool IsMainFrame() const override { return true; }

private:

FakePageTimingMetricsIPCSender fake_timing_ipc_sender_;