Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)
Patch Set: improve test comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h" 5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 ? PageLoadTiming() 50 ? PageLoadTiming()
51 : fake_timing_ipc_sender_.expected_timings().back(); 51 : fake_timing_ipc_sender_.expected_timings().back();
52 } 52 }
53 53
54 void VerifyExpectedTimings() const { 54 void VerifyExpectedTimings() const {
55 fake_timing_ipc_sender_.VerifyExpectedTimings(); 55 fake_timing_ipc_sender_.VerifyExpectedTimings();
56 } 56 }
57 57
58 bool ShouldSendMetrics() const override { return true; } 58 bool ShouldSendMetrics() const override { return true; }
59 bool HasNoRenderFrame() const override { return false; } 59 bool HasNoRenderFrame() const override { return false; }
60 bool IsMainFrame() const override { return true; }
60 61
61 private: 62 private:
62 FakePageTimingMetricsIPCSender fake_timing_ipc_sender_; 63 FakePageTimingMetricsIPCSender fake_timing_ipc_sender_;
63 mutable std::unique_ptr<base::Timer> mock_timer_; 64 mutable std::unique_ptr<base::Timer> mock_timer_;
64 }; 65 };
65 66
66 typedef testing::Test MetricsRenderFrameObserverTest; 67 typedef testing::Test MetricsRenderFrameObserverTest;
67 68
68 TEST_F(MetricsRenderFrameObserverTest, NoMetrics) { 69 TEST_F(MetricsRenderFrameObserverTest, NoMetrics) {
69 TestMetricsRenderFrameObserver observer; 70 TestMetricsRenderFrameObserver observer;
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 timing_2.first_layout = first_layout_2; 187 timing_2.first_layout = first_layout_2;
187 timing_2.dom_content_loaded_event_start = dom_event_2; 188 timing_2.dom_content_loaded_event_start = dom_event_2;
188 timing_2.load_event_start = load_event_2; 189 timing_2.load_event_start = load_event_2;
189 observer.ExpectPageLoadTiming(timing_2); 190 observer.ExpectPageLoadTiming(timing_2);
190 191
191 observer.DidChangePerformanceTiming(); 192 observer.DidChangePerformanceTiming();
192 mock_timer2->Fire(); 193 mock_timer2->Fire();
193 } 194 }
194 195
195 } // namespace page_load_metrics 196 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698