Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)
Patch Set: improve test comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
index 0f0a28bf0d0b7a779bb4c124bc71339bff3c3d28..d37b673b9f53f7a0d9f4676cde8330481ef60344 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
@@ -20,8 +20,11 @@ namespace page_load_metrics {
class PageTimingMetricsSender;
-// MetricsRenderFrameObserver observes RenderFrame notifications, and
-// sends page load timing information to the browser process over IPC.
+// MetricsRenderFrameObserver observes RenderFrame notifications, and sends page
+// load timing information to the browser process over IPC. A
+// MetricsRenderFrameObserver is instantiated for each frame (main frames and
+// child frames). MetricsRenderFrameObserver dispatches timing and metadata
+// updates for main frames, but only metadata updates for child frames.
class MetricsRenderFrameObserver : public content::RenderFrameObserver {
public:
explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
@@ -35,6 +38,10 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {
bool is_same_page_navigation) override;
void OnDestruct() override;
+ // Invoked when a frame is going away. This is our last chance to send IPCs
+ // before being destroyed.
+ void FrameDetached() override;
+
private:
// Will be null when we're not actively sending metrics.
std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
@@ -44,6 +51,7 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {
virtual PageLoadTiming GetTiming() const;
virtual std::unique_ptr<base::Timer> CreateTimer() const;
virtual bool HasNoRenderFrame() const;
+ virtual bool IsMainFrame() const;
DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
};

Powered by Google App Engine
This is Rietveld 408576698