Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.h

Issue 2737563007: Add support for tracking loading behavior of child frames. (Closed)
Patch Set: improve test comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.h
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.h b/chrome/browser/page_load_metrics/page_load_tracker.h
index c08628d0d7236c1f13edb318241a19fee8fc8e6f..259d1bd64539764c4b799eebfb3a9b9fc6e91979 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.h
+++ b/chrome/browser/page_load_metrics/page_load_tracker.h
@@ -107,6 +107,9 @@ enum InternalErrorLoadEvent {
// No page load end time was recorded for this page load.
ERR_NO_PAGE_LOAD_END_TIME,
+ // Received a timing update from a subframe.
+ ERR_TIMING_IPC_FROM_SUBFRAME,
+
// Add values before this final count.
ERR_LAST_ENTRY,
};
@@ -160,6 +163,8 @@ class PageLoadTracker {
bool UpdateTiming(const PageLoadTiming& timing,
const PageLoadMetadata& metadata);
+ void UpdateChildMetadata(const PageLoadMetadata& child_metadata);
Charlie Harrison 2017/03/09 16:21:29 I think it deserves a comment for why this is sepa
Bryan McQuade 2017/03/09 17:36:32 good idea, done
+
void OnLoadedResource(const ExtraRequestInfo& extra_request_info);
// Signals that we should stop tracking metrics for the associated page load.
@@ -294,7 +299,8 @@ class PageLoadTracker {
bool started_in_foreground_;
PageLoadTiming timing_;
- PageLoadMetadata metadata_;
+ PageLoadMetadata main_frame_metadata_;
+ PageLoadMetadata child_frame_metadata_;
ui::PageTransition page_transition_;

Powered by Google App Engine
This is Rietveld 408576698