Remove ChildProcess.HangRendererType.

Remove ChildProcess.HangRendererType.

It was used to distinguish hang types in the big hang timer in RenderWidgetHostImpl, but that timer is now only used for a single type of hang.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2737553003
Cr-Commit-Position: refs/heads/master@{#455764}
Committed: https://chromium.googlesource.com/chromium/src/+/ce79930d02031cfe9ba94249937643f99a2f55e8

[Avi (use Gerrit), 2017-03-06 20:11:11]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2017-03-06 20:11:12]

Description was changed from

==========
Remove ChildProcess.HangRendererType.

BUG=418266
==========

to

==========
Remove ChildProcess.HangRendererType.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-03-06 20:12:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-06 20:25:19]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 20:25:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 21:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:33:25]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Avi (use Gerrit), 2017-03-06 21:47:37]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 21:48:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:17:35]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-03-07 00:08:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 00:10:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 00:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 00:20:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2017-03-07 16:24:58]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 16:25:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 16:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:41:05]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-03-07 16:46:47]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 16:47:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 16:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:59:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2017-03-07 17:08:26]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 17:09:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 17:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 17:15:57]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Avi (use Gerrit), 2017-03-07 17:17:22]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 17:18:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-07 17:56:10]

avi@chromium.org changed reviewers:
+ clamy@chromium.org, isherman@chromium.org, sky@chromium.org

[Avi (use Gerrit), 2017-03-07 17:56:10]

Scott: chrome/
Ilya: histograms
Camille: everything else

[Avi (use Gerrit), 2017-03-07 17:56:53]

Description was changed from

==========
Remove ChildProcess.HangRendererType.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove ChildProcess.HangRendererType.

It was used to distinguish hang types in the big hang timer in
RenderWidgetHostImpl, but that timer is now only used for a single type of hang.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-03-07 18:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:45:03]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-07 21:48:27]

LGTM

[Ilya Sherman, 2017-03-08 01:29:18]

LGTM, thanks.

[Avi (use Gerrit), 2017-03-09 00:09:04]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 00:09:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:00:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2017-03-09 02:39:41]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 02:40:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:49:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 02:49:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2017-03-09 02:51:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 02:51:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 02:59:40]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[clamy, 2017-03-09 13:40:41]

Thanks for the cleanup! Lgtm with nits.

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:961: if
(in_flight_event_count_ > 0 && !is_hidden_) {
nit: no longer need for braces.

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:972: if
(hang_monitor_timeout_) {
Same here.

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:2101: if (!is_hidden_)
{
Same here.

[Avi (use Gerrit), 2017-03-09 15:25:27]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-03-09 15:25:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, sky@chromium.org, clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2737553003/#ps140001
(title: "rebase to tot")

[commit-bot: I haz the power, 2017-03-09 15:25:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-09 15:31:22]

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:961: if
(in_flight_event_count_ > 0 && !is_hidden_) {
On 2017/03/09 13:40:40, clamy wrote:
> nit: no longer need for braces.

Done.

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:972: if
(hang_monitor_timeout_) {
On 2017/03/09 13:40:40, clamy wrote:
> Same here.

Done.

https://codereview.chromium.org/2737553003/diff/120001/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:2101: if (!is_hidden_)
{
On 2017/03/09 13:40:41, clamy wrote:
> Same here.

Done.

[commit-bot: I haz the power, 2017-03-09 16:35:05]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489073127442130,
"parent_rev": "2cdd3bc1bae9ff0f2a2e6c4408e646e32de1e9f0", "commit_rev":
"ce79930d02031cfe9ba94249937643f99a2f55e8"}

[commit-bot: I haz the power, 2017-03-09 16:36:54]

Description was changed from

==========
Remove ChildProcess.HangRendererType.

It was used to distinguish hang types in the big hang timer in
RenderWidgetHostImpl, but that timer is now only used for a single type of hang.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove ChildProcess.HangRendererType.

It was used to distinguish hang types in the big hang timer in
RenderWidgetHostImpl, but that timer is now only used for a single type of hang.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2737553003
Cr-Commit-Position: refs/heads/master@{#455764}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce79930d02031cfe9ba942499376...
==========

[commit-bot: I haz the power, 2017-03-09 16:36:56]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/ce79930d02031cfe9ba942499376...