|
|
Created:
3 years, 9 months ago by estevenson Modified:
3 years, 9 months ago CC:
chromium-reviews, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused MonochromeApplication template code.
BUG=698004
Review-Url: https://codereview.chromium.org/2737523003
Cr-Commit-Position: refs/heads/master@{#458407}
Committed: https://chromium.googlesource.com/chromium/src/+/a0deb934a1ad2505bf0b9862adc8201cfcda0d68
Patch Set 1 #Patch Set 2 : Reeebase #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
estevenson@chromium.org changed reviewers: + agrieve@chromium.org
ptal Andrew
On 2017/03/16 18:18:05, estevenson wrote: > ptal Andrew lgtm
The CQ bit was checked by estevenson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
estevenson@chromium.org changed reviewers: + tedchoc@chromium.org
+ted for OWNERS, thanks!
lgtm
The CQ bit was checked by estevenson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2737523003/#ps20001 (title: "Reeebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by estevenson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490104596791310, "parent_rev": "dd765c0d5ff5089329188018ac826e0728cad15e", "commit_rev": "a0deb934a1ad2505bf0b9862adc8201cfcda0d68"}
Message was sent while issue was closed.
Description was changed from ========== Remove unused MonochromeApplication template code. BUG=698004 ========== to ========== Remove unused MonochromeApplication template code. BUG=698004 Review-Url: https://codereview.chromium.org/2737523003 Cr-Commit-Position: refs/heads/master@{#458407} Committed: https://chromium.googlesource.com/chromium/src/+/a0deb934a1ad2505bf0b9862adc8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a0deb934a1ad2505bf0b9862adc8... |