Fix compositor_unittests with Ozone X11.

Fix compositor_unittests with Ozone X11.

Some of the tests in compositor_unittests use OSMesa to draw but
TestCompositorHostOzone never creates an AccereleratedWidget. This works
fine with the headless OSMesa implementation, since it never draws to
the AcceleratedWidget, but won't work with GLSurfaceOSMesaX11 which
draws to an XWindow.

Create a PlatformWindow using the OzonePlatform object. This will
produce an AcceleratedWidget appropriately.

BUG=698780
Review-Url: https://codereview.chromium.org/2737513003
Cr-Commit-Position: refs/heads/master@{#455210}
Committed: https://chromium.googlesource.com/chromium/src/+/bf2bb744c704f16735d19c617f69beaba236db9b

[kylechar, 2017-03-06 18:11:06]

Description was changed from

==========
Fix compositor_unittests with Ozone X11.

Some of the tests in compositor_unittests use OSMesa to draw. The
TestCompositorHostOzone implementation never creates an
AccereleratedWidget.

BUG=TBD
==========

to

==========
Fix compositor_unittests with Ozone X11.

Some of the tests in compositor_unittests use OSMesa to draw but
TestCompositorHostOzone never creates an AccereleratedWidget. This works
fine with the headless OSMesa implementation, since it never draws to
the AcceleratedWidget, but won't work with GLSurfaceOSMesaX11 which
draws to an XWindow.

Create a PlatformWindow using the OzonePlatform object. This will
produce an AcceleratedWidget appropriately.

BUG=698780
==========

[kylechar, 2017-03-06 18:12:14]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 18:12:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-06 19:51:39]

kylechar@chromium.org changed reviewers:
+ danakj@chromium.org, sadrul@chromium.org

[kylechar, 2017-03-06 19:51:40]

+danakj for ui/compositor/*
+sadrul for DEPS

[danakj, 2017-03-06 20:56:16]

LGTM

https://codereview.chromium.org/2737513003/diff/40001/ui/compositor/test/test...
File ui/compositor/test/test_suite.cc (right):

https://codereview.chromium.org/2737513003/diff/40001/ui/compositor/test/test...
ui/compositor/test/test_suite.cc:38: #if defined(USE_OZONE)
nit: group with GLSurface init

[sadrul, 2017-03-06 21:47:55]

stamp lgtm

[kylechar, 2017-03-06 21:50:39]

Thanks!

https://codereview.chromium.org/2737513003/diff/40001/ui/compositor/test/test...
File ui/compositor/test/test_suite.cc (right):

https://codereview.chromium.org/2737513003/diff/40001/ui/compositor/test/test...
ui/compositor/test/test_suite.cc:38: #if defined(USE_OZONE)
On 2017/03/06 20:56:16, danakj wrote:
> nit: group with GLSurface init

Done.

[kylechar, 2017-03-06 21:50:40]

Thanks!

https://codereview.chromium.org/2737513003/diff/40001/ui/compositor/test/test...
File ui/compositor/test/test_suite.cc (right):

https://codereview.chromium.org/2737513003/diff/40001/ui/compositor/test/test...
ui/compositor/test/test_suite.cc:38: #if defined(USE_OZONE)
On 2017/03/06 20:56:16, danakj wrote:
> nit: group with GLSurface init

Done.

[kylechar, 2017-03-06 21:51:26]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-03-06 21:51:27]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2737513003/#ps60001
(title: "Group.")

[commit-bot: I haz the power, 2017-03-06 21:52:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:05:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kylechar, 2017-03-07 00:12:15]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-03-07 00:13:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:30:49]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kylechar, 2017-03-07 13:32:04]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 13:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-07 14:53:46]

On 2017/03/07 01:30:49, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

I have no idea how this is breaking a Windows test. None of the changes are even
compiled on Windows. It's failed a couples times now though, will investigate
further later today.

[kylechar, 2017-03-07 15:00:04]

On 2017/03/07 14:53:46, kylechar wrote:
> On 2017/03/07 01:30:49, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> 
> I have no idea how this is breaking a Windows test. None of the changes are
even
> compiled on Windows. It's failed a couples times now though, will investigate
> further later today.

The test is just broken by the looks of things.

[commit-bot: I haz the power, 2017-03-07 16:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:07:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kylechar, 2017-03-07 17:41:14]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 17:42:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:59:27]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-03-07 18:59:52]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-03-07 19:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 20:52:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488913192184570,
"parent_rev": "79debcb11fbe23b7951ecdbf1721c490319f54e6", "commit_rev":
"bf2bb744c704f16735d19c617f69beaba236db9b"}

[commit-bot: I haz the power, 2017-03-07 20:53:13]

Description was changed from

==========
Fix compositor_unittests with Ozone X11.

Some of the tests in compositor_unittests use OSMesa to draw but
TestCompositorHostOzone never creates an AccereleratedWidget. This works
fine with the headless OSMesa implementation, since it never draws to
the AcceleratedWidget, but won't work with GLSurfaceOSMesaX11 which
draws to an XWindow.

Create a PlatformWindow using the OzonePlatform object. This will
produce an AcceleratedWidget appropriately.

BUG=698780
==========

to

==========
Fix compositor_unittests with Ozone X11.

Some of the tests in compositor_unittests use OSMesa to draw but
TestCompositorHostOzone never creates an AccereleratedWidget. This works
fine with the headless OSMesa implementation, since it never draws to
the AcceleratedWidget, but won't work with GLSurfaceOSMesaX11 which
draws to an XWindow.

Create a PlatformWindow using the OzonePlatform object. This will
produce an AcceleratedWidget appropriately.

BUG=698780

Review-Url: https://codereview.chromium.org/2737513003
Cr-Commit-Position: refs/heads/master@{#455210}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf2bb744c704f16735d19c617f69...
==========

[commit-bot: I haz the power, 2017-03-07 20:53:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf2bb744c704f16735d19c617f69...