Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2737493002: [arm64][turbofan] Do not use ubfx for shr+and combination for mask=0. (Closed)

Created:
3 years, 9 months ago by ahaas
Modified:
3 years, 9 months ago
Reviewers:
titzer, v8-arm-ports
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64][turbofan] Do not use ubfx for shr+and combination for mask=0. R=titzer@chromium.org, v8-arm-ports@googlegroups.com BUG=v8:6046 Review-Url: https://codereview.chromium.org/2737493002 Cr-Commit-Position: refs/heads/master@{#43643} Committed: https://chromium.googlesource.com/v8/v8/+/040fa762dfa9d57b99588bb3b3219fe5215f271d

Patch Set 1 #

Patch Set 2 : Also a problem for Word32Shr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ahaas
3 years, 9 months ago (2017-03-06 12:19:04 UTC) #1
titzer
On 2017/03/06 12:19:04, ahaas wrote: lgtm
3 years, 9 months ago (2017-03-06 13:59:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737493002/20001
3 years, 9 months ago (2017-03-07 14:19:53 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 14:54:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/040fa762dfa9d57b99588bb3b3219fe5215...

Powered by Google App Engine
This is Rietveld 408576698