Reland Fix handling of device cloud signing policy key rotation

Reland Fix handling of device cloud signing policy key rotation

The original CL (crrev.com/2558543003) was reverted due to the failure
of the added test KeyRotationDeviceCloudPolicyTest.Basic.

This CL fixes this test by fixing the incorrect usage of DCHECK in the
fake class for testing: the DCHECK erroneously contained an actual
piece of logic.

Original CL's description:

> This CL fixes issues with handling of the signing key rotation for the
> device policy. There were some issues with not loading the updated
> owner key right after the new policy is stored. Even though the key
> would eventually be loaded thanks to the OwnerKeySet signal emitted
> by the session manager, there may be some window during which the old
> key is still used on the Chrome side.
>
> Also the CL adds a browser end-to-end test for browser policy key
> rotation (using a local policy test server). Some fake testing-only
> stubs were also fixed in order to support changing the signing keys
> (similar to how this is handled by the session manager).
>
> BUG=671659, 668716
> TEST=new browser test
>
> Review-Url: https://codereview.chromium.org/2558543003
> Cr-Commit-Position: refs/heads/master@{#454506}
> Committed: https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc04c8be2cfc20

BUG=671659, 668716
TEST=new browser test
TBR=stevenjb@chromium.org, atwilson@chromium.org
TBR_REASON=The CL is almost identical to the one that was already
   reviewed, except for fixing a small stupid bug in the test.

Review-Url: https://codereview.chromium.org/2737483006
Cr-Commit-Position: refs/heads/master@{#455075}
Committed: https://chromium.googlesource.com/chromium/src/+/8aaab6cd51f40e6ca50c01423f64c49d5bbb150f

[emaxx, 2017-03-07 12:36:16]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 12:36:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emaxx, 2017-03-07 12:37:23]

Description was changed from

==========
Reland Fix handling of device cloud signing policy key rotation

The original CL (crrev.com/2558543003) was reverted due to the failure
of the added test KeyRotationDeviceCloudPolicyTest.Basic.

This CL fixes this test by fixing the incorrect usage of DCHECK in the
fake class for testing: the DCHECK erroneously contained an actual
piece of logic.

Original CL's description:

> This CL fixes issues with handling of the signing key rotation for the
> device policy. There were some issues with not loading the updated
> owner key right after the new policy is stored. Even though the key
> would eventually be loaded thanks to the OwnerKeySet signal emitted
> by the session manager, there may be some window during which the old
> key is still used on the Chrome side.
>
> Also the CL adds a browser end-to-end test for browser policy key
> rotation (using a local policy test server). Some fake testing-only
> stubs were also fixed in order to support changing the signing keys
> (similar to how this is handled by the session manager).
>
> BUG=671659, 668716
> TEST=new browser test
>
> Review-Url: https://codereview.chromium.org/2558543003
> Cr-Commit-Position: refs/heads/master@{#454506}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc...

BUG=671659, 668716
TEST=new browser test
TBR=stevenjb@chromium.org, atwilson@chromium.org
TBR_REASON=The CL is almost identical to the one that was already
   reviewed, except for fixing the stupid bug in the test.
==========

to

==========
Reland Fix handling of device cloud signing policy key rotation

The original CL (crrev.com/2558543003) was reverted due to the failure
of the added test KeyRotationDeviceCloudPolicyTest.Basic.

This CL fixes this test by fixing the incorrect usage of DCHECK in the
fake class for testing: the DCHECK erroneously contained an actual
piece of logic.

Original CL's description:

> This CL fixes issues with handling of the signing key rotation for the
> device policy. There were some issues with not loading the updated
> owner key right after the new policy is stored. Even though the key
> would eventually be loaded thanks to the OwnerKeySet signal emitted
> by the session manager, there may be some window during which the old
> key is still used on the Chrome side.
>
> Also the CL adds a browser end-to-end test for browser policy key
> rotation (using a local policy test server). Some fake testing-only
> stubs were also fixed in order to support changing the signing keys
> (similar to how this is handled by the session manager).
>
> BUG=671659, 668716
> TEST=new browser test
>
> Review-Url: https://codereview.chromium.org/2558543003
> Cr-Commit-Position: refs/heads/master@{#454506}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc...

BUG=671659, 668716
TEST=new browser test
TBR=stevenjb@chromium.org, atwilson@chromium.org
TBR_REASON=The CL is almost identical to the one that was already
   reviewed, except for fixing a small stupid bug in the test.
==========

[Andrew T Wilson (Slow), 2017-03-07 13:11:27]

lgtm

[commit-bot: I haz the power, 2017-03-07 14:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:44:59]

Dry run: This issue passed the CQ dry run.

[emaxx, 2017-03-07 14:46:02]

The CQ bit was checked by emaxx@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:46:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 14:57:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488897962568240, "parent_rev":
"4764a6211c89fbeee0f900dc9750a2232c8fb09b", "commit_rev":
"8aaab6cd51f40e6ca50c01423f64c49d5bbb150f"}

[commit-bot: I haz the power, 2017-03-07 14:58:19]

Description was changed from

==========
Reland Fix handling of device cloud signing policy key rotation

The original CL (crrev.com/2558543003) was reverted due to the failure
of the added test KeyRotationDeviceCloudPolicyTest.Basic.

This CL fixes this test by fixing the incorrect usage of DCHECK in the
fake class for testing: the DCHECK erroneously contained an actual
piece of logic.

Original CL's description:

> This CL fixes issues with handling of the signing key rotation for the
> device policy. There were some issues with not loading the updated
> owner key right after the new policy is stored. Even though the key
> would eventually be loaded thanks to the OwnerKeySet signal emitted
> by the session manager, there may be some window during which the old
> key is still used on the Chrome side.
>
> Also the CL adds a browser end-to-end test for browser policy key
> rotation (using a local policy test server). Some fake testing-only
> stubs were also fixed in order to support changing the signing keys
> (similar to how this is handled by the session manager).
>
> BUG=671659, 668716
> TEST=new browser test
>
> Review-Url: https://codereview.chromium.org/2558543003
> Cr-Commit-Position: refs/heads/master@{#454506}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc...

BUG=671659, 668716
TEST=new browser test
TBR=stevenjb@chromium.org, atwilson@chromium.org
TBR_REASON=The CL is almost identical to the one that was already
   reviewed, except for fixing a small stupid bug in the test.
==========

to

==========
Reland Fix handling of device cloud signing policy key rotation

The original CL (crrev.com/2558543003) was reverted due to the failure
of the added test KeyRotationDeviceCloudPolicyTest.Basic.

This CL fixes this test by fixing the incorrect usage of DCHECK in the
fake class for testing: the DCHECK erroneously contained an actual
piece of logic.

Original CL's description:

> This CL fixes issues with handling of the signing key rotation for the
> device policy. There were some issues with not loading the updated
> owner key right after the new policy is stored. Even though the key
> would eventually be loaded thanks to the OwnerKeySet signal emitted
> by the session manager, there may be some window during which the old
> key is still used on the Chrome side.
>
> Also the CL adds a browser end-to-end test for browser policy key
> rotation (using a local policy test server). Some fake testing-only
> stubs were also fixed in order to support changing the signing keys
> (similar to how this is handled by the session manager).
>
> BUG=671659, 668716
> TEST=new browser test
>
> Review-Url: https://codereview.chromium.org/2558543003
> Cr-Commit-Position: refs/heads/master@{#454506}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6581fa97d9ac35a9c541856a0acc...

BUG=671659, 668716
TEST=new browser test
TBR=stevenjb@chromium.org, atwilson@chromium.org
TBR_REASON=The CL is almost identical to the one that was already
   reviewed, except for fixing a small stupid bug in the test.

Review-Url: https://codereview.chromium.org/2737483006
Cr-Commit-Position: refs/heads/master@{#455075}
Committed:
https://chromium.googlesource.com/chromium/src/+/8aaab6cd51f40e6ca50c01423f64...
==========

[commit-bot: I haz the power, 2017-03-07 14:58:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8aaab6cd51f40e6ca50c01423f64...