Add a Certificate Viewer link to the Page Info dropdown

chrome/browser/ui/views/page_info/page_info_popup_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/page_info/page_info_popup_view.h"
 
 #include <stddef.h>
 
 #include <algorithm>
-#include <vector>
+#include <utility>
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/certificate_viewer.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/layout_constants.h"
 #include "chrome/browser/ui/page_info/page_info.h"
 #include "chrome/browser/ui/views/collected_cookies_views.h"
 #include "chrome/browser/ui/views/harmony/chrome_typography.h"
 #include "chrome/browser/ui/views/harmony/layout_delegate.h"
 #include "chrome/browser/ui/views/page_info/chosen_object_row.h"
 #include "chrome/browser/ui/views/page_info/non_accessible_image_view.h"
 #include "chrome/browser/ui/views/page_info/permission_selector_row.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/strings/grit/components_chromium_strings.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/common/constants.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 39 matching lines @@
 
 // Margin and padding values for the |PopupHeaderView|.
 const int kHeaderMarginBottom = 10;
 const int kHeaderPaddingBottom = 13;
 
 // Spacing between labels in the header.
 const int kHeaderLabelSpacing = 4;
 
 // Site Settings Section -------------------------------------------------------
 
-// Spacing above and below the cookies view.
-const int kCookiesViewVerticalPadding = 6;
+// Spacing above and below the cookies and certificate views.
+const int kSubViewsVerticalPadding = 6;
 
 // Spacing between a permission image and the text.
 const int kPermissionImageSpacing = 6;
 
 // Spacing between rows in the site settings section
 const int kPermissionsVerticalSpacing = 12;
 
 // Spacing between the label and the menu.
 const int kPermissionMenuSpacing = 16;
 
 // Button/styled label/link IDs ------------------------------------------------
 const int BUTTON_CLOSE = 1337;
 const int STYLED_LABEL_SECURITY_DETAILS = 1338;
 const int STYLED_LABEL_RESET_CERTIFICATE_DECISIONS = 1339;
 const int LINK_COOKIE_DIALOG = 1340;
 const int LINK_SITE_SETTINGS = 1341;
+const int LINK_CERTIFICATE_VIEWER = 1342;
 
 // The default, ui::kTitleFontSizeDelta, is too large for the page info
 // bubble (e.g. +3). Use +1 to obtain a smaller font.
 constexpr int kSummaryFontSizeDelta = 1;
 
 // Adds a ColumnSet on |layout| with a single View column and padding columns
 // on either side of it with |margin| width.
 void AddColumnWithSideMargin(views::GridLayout* layout, int margin, int id) {
   views::ColumnSet* column_set = layout->AddColumnSet(id);
   column_set->AddPaddingColumn(0, margin);
@@ skipping 262 matching lines @@
     Profile* profile,
     content::WebContents* web_contents,
     const GURL& url,
     const security_state::SecurityInfo& security_info)
     : content::WebContentsObserver(web_contents),
       BubbleDialogDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),
       profile_(profile),
       header_(nullptr),
       separator_(nullptr),
       site_settings_view_(nullptr),
+      certificate_view_(nullptr),
+      certificate_viewer_link_(nullptr),
       cookies_view_(nullptr),
       cookie_dialog_link_(nullptr),
       permissions_view_(nullptr),
       weak_factory_(this) {
   g_shown_popup_type = POPUP_PAGE_INFO;
   set_parent_window(parent_window);
 
   // Compensate for built-in vertical padding in the anchor view's image.
   set_anchor_view_insets(gfx::Insets(
       GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
@@ skipping 155 matching lines @@
 
     const int cookies_view_column = 0;
     views::ColumnSet* column_set = layout->AddColumnSet(cookies_view_column);
     column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 0,
                           views::GridLayout::FIXED, kPermissionIconColumnWidth,
                           0);
     column_set->AddPaddingColumn(0, kPermissionImageSpacing);
     column_set->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL,
                           0, views::GridLayout::USE_PREF, 0, 0);
 
-    layout->AddPaddingRow(0, kCookiesViewVerticalPadding);
+    layout->AddPaddingRow(0, kSubViewsVerticalPadding);
 
     layout->StartRow(1, cookies_view_column);
     PageInfoUI::PermissionInfo info;
     info.type = CONTENT_SETTINGS_TYPE_COOKIES;
     info.setting = CONTENT_SETTING_ALLOW;
     info.is_incognito =
         Profile::FromBrowserContext(web_contents()->GetBrowserContext())
             ->IsOffTheRecord();
     views::ImageView* icon = new NonAccessibleImageView();
     const gfx::Image& image = PageInfoUI::GetPermissionIcon(info);
     icon->SetImage(image.ToImageSkia());
     layout->AddView(
         icon, 1, 2, views::GridLayout::FILL,
-        // TODO: The vertical alignment may change to CENTER once Harmony is
-        // implemented. See https://crbug.com/512442#c48
+        // TODO(lgarron): The vertical alignment may change to CENTER once
+        // Harmony is implemented. See https://crbug.com/512442#c48
         views::GridLayout::LEADING);
 
     views::Label* cookies_label = new views::Label(
         l10n_util::GetStringUTF16(IDS_PAGE_INFO_TITLE_SITE_DATA),
         CONTEXT_BODY_TEXT_LARGE);
     layout->AddView(cookies_label);
     layout->StartRow(1, cookies_view_column);
     layout->SkipColumns(1);
 
     layout->AddView(cookie_dialog_link_);
 
-    layout->AddPaddingRow(0, kCookiesViewVerticalPadding);
+    layout->AddPaddingRow(0, kSubViewsVerticalPadding);
   }
 
   layout->Layout(cookies_view_);
   SizeToContents();
 }
 
 void PageInfoPopupView::SetPermissionInfo(
     const PermissionInfoList& permission_info_list,
     ChosenObjectInfoList chosen_object_info_list) {
   // When a permission is changed, PageInfo::OnSitePermissionChanged()
@@ skipping 71 matching lines @@
       identity_info.GetSecurityDescription();
 
   summary_text_ = security_description->summary;
   GetWidget()->UpdateWindowTitle();
 
   if (identity_info.certificate) {
     certificate_ = identity_info.certificate;
 
     if (identity_info.show_ssl_decision_revoke_button)
       header_->AddResetDecisionsLabel();
+
+    if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+            switches::kShowCertButton)) {
+      certificate_view_ = new views::View();
+      views::GridLayout* layout = static_cast<views::GridLayout*>(
+          certificate_view_->GetLayoutManager());
+      if (!layout) {
+        layout = new views::GridLayout(certificate_view_);
+        certificate_view_->SetLayoutManager(layout);
+
+        const int certificate_view_column = 0;
+        views::ColumnSet* column_set =
+            layout->AddColumnSet(certificate_view_column);
+        column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL,
+                              0, views::GridLayout::FIXED,
+                              kPermissionIconColumnWidth, 0);
+        column_set->AddPaddingColumn(0, kPermissionImageSpacing);
+        column_set->AddColumn(views::GridLayout::LEADING,
+                              views::GridLayout::FILL, 0,
+                              views::GridLayout::USE_PREF, 0, 0);
+
+        layout->AddPaddingRow(0, kSubViewsVerticalPadding);
+
+        layout->StartRow(1, certificate_view_column);
+
+        views::ImageView* icon = new NonAccessibleImageView();
+        const gfx::Image& image = PageInfoUI::GetCertificateIcon();
+        icon->SetImage(image.ToImageSkia());
+        layout->AddView(
+            icon, 1, 2, views::GridLayout::FILL,
+            // TODO(lgarron): The vertical alignment may change to CENTER once
+            // Harmony is implemented. See https://crbug.com/512442#c48
+            views::GridLayout::LEADING);
+
+        views::Label* certificate_label = new views::Label(
+            l10n_util::GetStringUTF16(IDS_PAGE_INFO_CERTIFICATE),
+            CONTEXT_BODY_TEXT_LARGE);
+        layout->AddView(certificate_label);
+        layout->StartRow(1, certificate_view_column);
+        layout->SkipColumns(1);
+
+        // The text of link to the Certificate Viewer varies depending on the
+        // validity of the Certificate.
+        certificate_viewer_link_ = new views::Link(l10n_util::GetStringUTF16(
+            (identity_info.identity_status ==
+             PageInfo::SITE_IDENTITY_STATUS_ERROR)
+                ? IDS_PAGE_INFO_CERTIFICATE_INVALID_LINK
+                : IDS_PAGE_INFO_CERTIFICATE_VALID_LINK));
+        certificate_viewer_link_->set_id(LINK_CERTIFICATE_VIEWER);
+        certificate_viewer_link_->set_listener(this);
+
+        layout->AddView(certificate_viewer_link_);
+      }
+
+      layout->Layout(certificate_view_);
+      site_settings_view_->AddChildViewAt(certificate_view_, 0);
+    }
   }
 
   header_->SetDetails(security_description->details);
 
   Layout();
   SizeToContents();
 }
 
 views::View* PageInfoPopupView::CreateSiteSettingsView(int side_margin) {
   views::View* site_settings_view = new views::View();
   views::BoxLayout* box_layout =
       new views::BoxLayout(views::BoxLayout::kVertical, side_margin, 0, 0);
   site_settings_view->SetLayoutManager(box_layout);
   box_layout->set_cross_axis_alignment(
       views::BoxLayout::CROSS_AXIS_ALIGNMENT_STRETCH);
 
   // Add cookies view.
   cookies_view_ = new views::View();
   site_settings_view->AddChildView(cookies_view_);
 
   return site_settings_view;
 }
 
 void PageInfoPopupView::HandleLinkClickedAsync(views::Link* source) {
-  // Both switch cases require accessing web_contents(), so we check it here.
+  // All switch cases require accessing web_contents(), so we check it here.
   if (web_contents() == nullptr || web_contents()->IsBeingDestroyed())
     return;
   switch (source->id()) {
     case LINK_SITE_SETTINGS:
       // TODO(crbug.com/655876): This opens the general Content Settings pane,
       // which is OK for now. But on Android, it opens a page specific to a
       // given origin that shows all of the settings for that origin. If/when
       // that's available on desktop we should link to that here, too.
       web_contents()->OpenURL(content::OpenURLParams(
           GURL(chrome::kChromeUIContentSettingsURL), content::Referrer(),
           WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
           false));
       presenter_->RecordPageInfoAction(
           PageInfo::PAGE_INFO_SITE_SETTINGS_OPENED);
       break;
     case LINK_COOKIE_DIALOG:
       // Count how often the Collected Cookies dialog is opened.
       presenter_->RecordPageInfoAction(
           PageInfo::PAGE_INFO_COOKIES_DIALOG_OPENED);
       new CollectedCookiesViews(web_contents());
       break;
+    case LINK_CERTIFICATE_VIEWER: {
+      gfx::NativeWindow top_window = web_contents()->GetTopLevelNativeWindow();
+      if (certificate_ && top_window) {
+        presenter_->RecordPageInfoAction(
+            PageInfo::PAGE_INFO_CERTIFICATE_DIALOG_OPENED);
+        ShowCertificateViewer(web_contents(), top_window, certificate_.get());
+      }
+    } break;
     default:
       NOTREACHED();
   }
 }
 
 void PageInfoPopupView::StyledLabelLinkClicked(views::StyledLabel* label,
                                                const gfx::Range& range,
                                                int event_flags) {
   switch (label->id()) {
     case STYLED_LABEL_SECURITY_DETAILS:
       web_contents()->OpenURL(content::OpenURLParams(
           GURL(chrome::kPageInfoHelpCenterURL), content::Referrer(),
           WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
           false));
       presenter_->RecordPageInfoAction(
           PageInfo::PAGE_INFO_CONNECTION_HELP_OPENED);
       break;
     case STYLED_LABEL_RESET_CERTIFICATE_DECISIONS:
       presenter_->OnRevokeSSLErrorBypassButtonPressed();
       GetWidget()->Close();
       break;
     default:
       NOTREACHED();
   }
 }