media/mp4/mp4_stream_parser.cc - Issue 27374002: Add support for avc3 codec string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/mp4_stream_parser.cc

Issue 27374002: Add support for avc3 codec string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/mp4_stream_parser.cc

diff --git a/media/mp4/mp4_stream_parser.cc b/media/mp4/mp4_stream_parser.cc

index 26cee44d14e8c9d2ac99108d4c8e8f1c87fa3ef0..19855abc231ab2f6a8f2b80f3c1deed2d8e735e6 100644

--- a/media/mp4/mp4_stream_parser.cc

+++ b/media/mp4/mp4_stream_parser.cc

@@ -268,9 +268,7 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {

desc_idx = 0;

const VideoSampleEntry& entry = samp_descr.video_entries[desc_idx];

- if (!(entry.format == FOURCC_AVC1 ||

- (entry.format == FOURCC_ENCV &&

- entry.sinf.format.format == FOURCC_AVC1))) {

+ if (!entry.IsFormatValid()) {

MEDIA_LOG(log_cb_) << "Unsupported video format 0x"

<< std::hex << entry.format << " in stsd box.";

return false;

« no previous file with comments | « media/mp4/fourccs.h ('k') | media/test/data/bear-1280x720-v_frag-avc3.mp4 » ('j') | no next file with comments »