Implement the new Photo picker, part one.

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 0c03ffd47cdbb79e8029f692995f52ddec7b080c..855aa4cb50a5b5ab80d2dd111f0a2e4caa0d9c0a 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -810,6 +810,9 @@ const FeatureEntry kFeatureEntries[] = {
     {"enable-osk-overscroll", IDS_FLAGS_ENABLE_OSK_OVERSCROLL_NAME,
      IDS_FLAGS_ENABLE_OSK_OVERSCROLL_DESCRIPTION, kOsAndroid,
      SINGLE_VALUE_TYPE(switches::kEnableOSKOverscroll)},
+    {"enable-new-photo-picker", IDS_FLAGS_NEW_PHOTO_PICKER_NAME,
+     IDS_FLAGS_NEW_PHOTO_PICKER_DESCRIPTION, kOsAndroid,
+     FEATURE_VALUE_TYPE(chrome::android::kEnableNewPhotoPicker)},

[Michael van Ouwerkerk, 2017/03/14 15:57:27]

just kNewPhotoPicker seems cleaner

[Finnur, 2017/03/15 13:25:06]

../../chrome/browser/about_flags.cc:815:25: error: use of undeclared identifier
'kEnableNewPhotoPicker'; did you mean 'chrome::android::kEnableNewPhotoPicker'?
     FEATURE_VALUE_TYPE(kEnableNewPhotoPicker)},

[Michael van Ouwerkerk, 2017/03/15 13:28:38]

What I meant was that none of the other features in chrome_feature_list.cc have
'Enable' as part of their name, so you should rename it to kNewPhotoPicker.

[Finnur, 2017/03/15 14:45:40]

Ah, right! Done. Thanks for the review, Michael!

     {"enable-usermedia-screen-capturing", IDS_FLAGS_MEDIA_SCREEN_CAPTURE_NAME,
      IDS_FLAGS_MEDIA_SCREEN_CAPTURE_DESCRIPTION, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kUserMediaScreenCapturing)},