Implement the new Photo picker, part one.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 792 matching lines @@
      IDS_FLAGS_WEBRTC_STUN_ORIGIN_DESCRIPTION, kOsAll,
      SINGLE_VALUE_TYPE(switches::kEnableWebRtcStunOrigin)},
     {"WebRtcUseEchoCanceller3", IDS_FLAGS_WEBRTC_ECHO_CANCELLER_3_NAME,
      IDS_FLAGS_WEBRTC_ECHO_CANCELLER_3_DESCRIPTION, kOsAll,
      FEATURE_VALUE_TYPE(features::kWebRtcUseEchoCanceller3)},
 #endif  // ENABLE_WEBRTC
 #if defined(OS_ANDROID)
     {"enable-osk-overscroll", IDS_FLAGS_ENABLE_OSK_OVERSCROLL_NAME,
      IDS_FLAGS_ENABLE_OSK_OVERSCROLL_DESCRIPTION, kOsAndroid,
      SINGLE_VALUE_TYPE(switches::kEnableOSKOverscroll)},
+    {"enable-new-photo-picker", IDS_FLAGS_NEW_PHOTO_PICKER_NAME,
+     IDS_FLAGS_NEW_PHOTO_PICKER_DESCRIPTION, kOsAndroid,
+     FEATURE_VALUE_TYPE(chrome::android::kEnableNewPhotoPicker)},

[Michael van Ouwerkerk, 2017/03/14 15:57:27]

just kNewPhotoPicker seems cleaner

[Finnur, 2017/03/15 13:25:06]

../../chrome/browser/about_flags.cc:815:25: error: use of undeclared identifier
'kEnableNewPhotoPicker'; did you mean 'chrome::android::kEnableNewPhotoPicker'?
     FEATURE_VALUE_TYPE(kEnableNewPhotoPicker)},

[Michael van Ouwerkerk, 2017/03/15 13:28:38]

What I meant was that none of the other features in chrome_feature_list.cc have
'Enable' as part of their name, so you should rename it to kNewPhotoPicker.

[Finnur, 2017/03/15 14:45:40]

Ah, right! Done. Thanks for the review, Michael!

     {"enable-usermedia-screen-capturing", IDS_FLAGS_MEDIA_SCREEN_CAPTURE_NAME,
      IDS_FLAGS_MEDIA_SCREEN_CAPTURE_DESCRIPTION, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kUserMediaScreenCapturing)},
 #endif  // OS_ANDROID
 // Native client is compiled out when DISABLE_NACL is defined.
 #if !defined(DISABLE_NACL)
     {"enable-nacl", IDS_FLAGS_NACL_NAME, IDS_FLAGS_NACL_DESCRIPTION, kOsAll,
      SINGLE_VALUE_TYPE(switches::kEnableNaCl)},
     {"enable-nacl-debug", IDS_FLAGS_NACL_DEBUG_NAME,
      IDS_FLAGS_NACL_DEBUG_DESCRIPTION, kOsDesktop,
@@ skipping 1727 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags