Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2737383003:
Add a workaround for the load event not being called in image loader. (Closed)
|
Created:
3 years, 9 months ago by mtomasz Modified:
3 years, 9 months ago CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, takise Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a workaround for the load event not being called in image loader.
BUG=517741
TEST=Tested manually that reloading is fast.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2737383003
Cr-Commit-Position: refs/heads/master@{#456027}
Committed: https://chromium.googlesource.com/chromium/src/+/3dfe1c0a782aa80ffe367c0df7ad1be95cb46768
Patch Set 1 #Patch Set 2 : Fixed closure compiling error. #Messages
Total messages: 24 (15 generated)
Description was changed from ========== Add a workaround for the load event not being called in image loader. BUG=517741 TEST=Tested manually that reloading is fast. ========== to ========== Add a workaround for the load event not being called in image loader. BUG=517741 TEST=Tested manually that reloading is fast. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Add a workaround for the load event not being called in image loader. BUG=517741 TEST=Tested manually that reloading is fast. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add a workaround for the load event not being called in image loader. BUG=517741 TEST=Tested manually that reloading is fast. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
mtomasz@chromium.org changed reviewers: + hirono@chromium.org
@hirono: PTAL. Thanks.
More background here: crbug.com/699930
The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
hirono@google.com changed reviewers: + hirono@google.com
lgtm. Thank you for fixing this!
The CQ bit was checked by mtomasz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hirono@google.com Link to the patchset: https://codereview.chromium.org/2737383003/#ps20001 (title: "Fixed closure compiling error.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
fukino@chromium.org changed reviewers: + fukino@chromium.org
lgtm too.
Thanks!
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489135365885340,
"parent_rev": "6d55717cd047b3d79e3cc41ea1a4e7df50b8c171", "commit_rev":
"3dfe1c0a782aa80ffe367c0df7ad1be95cb46768"}
Message was sent while issue was closed.
Description was changed from ========== Add a workaround for the load event not being called in image loader. BUG=517741 TEST=Tested manually that reloading is fast. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add a workaround for the load event not being called in image loader. BUG=517741 TEST=Tested manually that reloading is fast. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2737383003 Cr-Commit-Position: refs/heads/master@{#456027} Committed: https://chromium.googlesource.com/chromium/src/+/3dfe1c0a782aa80ffe367c0df7ad... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3dfe1c0a782aa80ffe367c0df7ad... |
