Update MojoTestConnection Service Registration

Update MojoTestConnection Service Registration

MojoTestConnection is responsible for creating the inter-process mojo pipes.
These must be set on the command line for the child processes running individual
test cases.

It is also responsible for bringing up services. This however was being done at
test enqueuing time. When the remote service was brought down at the end of the
first test case, all registered services were having their pipes close. Thus
preventing subsequent tests from connecting.

This change moves the service registration until the child process is being
connected. This actually occurs after the previous test has completed.

mash.browser_tests.filter has also been updated to include more tests which are
passing locally. This way we get expanded coverage on the bots.

TEST=BrowserTests
BUG=678687
Review-Url: https://codereview.chromium.org/2737353003
Cr-Commit-Position: refs/heads/master@{#456192}
Committed: https://chromium.googlesource.com/chromium/src/+/5530deaf657350413318fb3181f45ebe0f1954ba

[jonross, 2017-03-09 22:03:42]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-03-09 22:03:43]

Hey sky@

This chance is an update to MojoTestConnection to change the startup time of the
services.

This allows for subsequent tests to have fresh services for their run.

PTAL

[sky, 2017-03-09 23:33:06]

LGTM

[jonross, 2017-03-09 23:35:34]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:16:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jonross, 2017-03-10 02:48:42]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:49:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 05:27:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 05:27:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jonross, 2017-03-10 21:34:48]

The CQ bit was checked by jonross@chromium.org

[jonross, 2017-03-10 21:34:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2737353003/#ps40001
(title: "Minimize filter to test arc startup crash")

[commit-bot: I haz the power, 2017-03-10 21:35:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 22:37:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489181688966190,
"parent_rev": "094b5e38f83ceebb408911139f194dd3705e54be", "commit_rev":
"5530deaf657350413318fb3181f45ebe0f1954ba"}

[commit-bot: I haz the power, 2017-03-10 22:37:58]

Description was changed from

==========
Update MojoTestConnection Service Registration

MojoTestConnection is responsible for creating the inter-process mojo pipes.
These must be set on the command line for the child processes running individual
test cases.

It is also responsible for bringing up services. This however was being done at
test enqueuing time. When the remote service was brought down at the end of the
first test case, all registered services were having their pipes close. Thus
preventing subsequent tests from connecting.

This change moves the service registration until the child process is being
connected. This actually occurs after the previous test has completed.

mash.browser_tests.filter has also been updated to include more tests which are
passing locally. This way we get expanded coverage on the bots.

TEST=BrowserTests
BUG=678687
==========

to

==========
Update MojoTestConnection Service Registration

MojoTestConnection is responsible for creating the inter-process mojo pipes.
These must be set on the command line for the child processes running individual
test cases.

It is also responsible for bringing up services. This however was being done at
test enqueuing time. When the remote service was brought down at the end of the
first test case, all registered services were having their pipes close. Thus
preventing subsequent tests from connecting.

This change moves the service registration until the child process is being
connected. This actually occurs after the previous test has completed.

mash.browser_tests.filter has also been updated to include more tests which are
passing locally. This way we get expanded coverage on the bots.

TEST=BrowserTests
BUG=678687

Review-Url: https://codereview.chromium.org/2737353003
Cr-Commit-Position: refs/heads/master@{#456192}
Committed:
https://chromium.googlesource.com/chromium/src/+/5530deaf657350413318fb3181f4...
==========

[commit-bot: I haz the power, 2017-03-10 22:37:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5530deaf657350413318fb3181f4...