Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2737273002: [DOM] Fix null namespace handling in Node.isDefaultNamespace(). (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DOM] Fix null namespace handling in Node.isDefaultNamespace(). - Fix the implementation bug. - Remove obsolete test in the legacy DOM conformance tests. - Add tests for DocumentType node to WPT. BUG=699812 Review-Url: https://codereview.chromium.org/2737273002 Cr-Commit-Position: refs/heads/master@{#456002} Committed: https://chromium.googlesource.com/chromium/src/+/089c67c27a4ea8c5a1aeafcc7674bff96298a1e3

Patch Set 1 #

Messages

Total messages: 14 (10 generated)
tkent
kochi@, would you review this please? No hurry.
3 years, 9 months ago (2017-03-09 07:29:34 UTC) #8
kochi
LGTM Nice code reduction!
3 years, 9 months ago (2017-03-10 02:24:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737273002/1
3 years, 9 months ago (2017-03-10 02:26:42 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 05:28:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/089c67c27a4ea8c5a1aeafcc7674...

Powered by Google App Engine
This is Rietveld 408576698