Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java

Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler (Closed)
Patch Set: Fully implemented, still needs tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
index 5eec37dbd14c765b8986964ec65ddb20f5d62703..db77f0fc1783648b3a4508caaf9dfe255b4dcf69 100644
--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
@@ -113,9 +113,6 @@ public class MinidumpUploadCallable implements Callable<Integer> {
Log.i(TAG, "Minidump cannot currently be uploaded due to network constraints.");
return UPLOAD_FAILURE;
}
-
- // The above checks should be at least as strict as the requirements for UMA uploads.
- assert mPermManager.isMetricsUploadPermitted();
gsennton 2017/03/13 17:57:17 Ideally, I would probably remove this in a separat
Ilya Sherman 2017/03/14 02:18:55 Done.
}
HttpURLConnection connection =

Powered by Google App Engine
This is Rietveld 408576698