components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java - Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler (Closed)

Patch Set: Fully implemented, still needs tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('K') | « chrome/browser/android/chrome_feature_list.cc ('k') | components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java » ('j') | components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

index d905db4adb9eddbe08e8f885d1ef5d21a4ba2d3a..96f56005ffb99921154422f1f70a5dad5e163862 100644

--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java

@@ -49,7 +49,7 @@ public class CrashFileManager {

Pattern.compile("\\.dmp([0-9]+)$\\z");

private static final Pattern MINIDUMP_PATTERN =

- Pattern.compile("\\.dmp([0-9]*)(\\.try([0-9]+))?\\z");

+ Pattern.compile("\\.(dmp|forced)([0-9]*)(\\.try([0-9]+))?\\z");

gsennton 2017/03/13 17:57:17 Will this change any behaviour in the old implemen

Ilya Sherman 2017/03/14 02:18:55 This does correct a bug in the old implementation,

private static final Pattern UPLOADED_MINIDUMP_PATTERN = Pattern.compile("\\.up([0-9]*)\\z");