chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java - Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler (Closed)

Patch Set: Fully implemented, still needs tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('k') | chrome/android/java_sources.gni » ('j') | components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

index 8bf871ae9981ea7933c1488111a26b29fde7411f..8877afffc67651826fdea6acc44abcbbd371fc64 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

@@ -304,7 +304,6 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage

* @return whether uploading usage metrics is currently permitted.

- @Override

public boolean isMetricsUploadPermitted() {

return isNetworkAvailable()

&& (isUsageAndCrashReportingPermittedByUser() || isUploadEnabledForTests());