android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java - Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java

Issue 2737263006: [Android Crash Reporting] Allow uploading minidumps via the JobScheduler (Closed)

Patch Set: Fully implemented, still needs tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java ('K') | « android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java ('k') | chrome/android/java/AndroidManifest.xml » ('j') | chrome/android/java/AndroidManifest.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java

index 87dc629f1c7d3abf096aedc7ff25fb5ddc644985..228e811ae458ca1d7f6f967cacc9a166c7b2b1eb 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java

@@ -127,7 +127,6 @@ public class MinidumpUploaderTest extends CrashTestCase {

new MockCrashReportingPermissionManager() {

{

mIsInSample = true;

- mIsPermitted = true;

mIsUserPermitted = true;

mIsCommandLineDisabled = false;

mIsNetworkAvailable = false; // Will cause us to fail uploads

@@ -513,7 +512,6 @@ public class MinidumpUploaderTest extends CrashTestCase {

// This setup ensures we depend on

// isUsageAndCrashReportingPermittedByUser().

mIsInSample = true;

- mIsPermitted = true;

mIsCommandLineDisabled = false;

mIsNetworkAvailable = true;

mIsEnabledForTests = false;