[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

Index: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
index 84d55ea487ea037f1c00134231373fbde918b556..34a802cc5c6da6019fcac837db06caa917868688 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
@@ -36,7 +36,10 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
     }
 
     @Override
-    public File createCrashDir() {
+    public File getCacheDir() {
+        // TODO(isherman): This actually results in the directory structure cache/crash/crash.  Is
+        // it worth fixing? We might lose pending crash reports in the nested dir if we do try a fix
+        // here...

[Ilya Sherman, 2017/03/13 03:12:09]

Gustav, WDYT?  (In either case, not a change I'd want to implement in this CL.)

[gsennton, 2017/03/13 17:57:17]

the directory structure is
cache/WebView_Crashes/Crash Reports/

(to fix this we would have to change CrashFileManager to not use "Crash
Reports/" directory - otherwise Monochrome and WebView will be using the same
directory to store its minidumps).
IMO this is not worth fixing.

[Ilya Sherman, 2017/03/14 02:18:55]

Ah, okay, this makes more sense now.  I renamed things a bit to hopefully
clarify the structure.

         return CrashReceiverService.createWebViewCrashDir(mContext);
     }
 
@@ -67,14 +70,6 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
             public boolean isCrashUploadDisabledByCommandLine() {
                 return false;
             }
-            /**
-             * This method is already represented by isClientInMetricsSample() and
-             * isNetworkAvailableForCrashUploads().
-             */
-            @Override
-            public boolean isMetricsUploadPermitted() {
-                return true;
-            }
             @Override
             public boolean isUsageAndCrashReportingPermittedByUser() {
                 return mPermittedByUser;