[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.crash;
 
 import android.content.Context;
 import android.net.ConnectivityManager;
 import android.net.NetworkInfo;
 import android.webkit.ValueCallback;
@@ skipping 18 matching lines @@
     private boolean mPermittedByUser = false;
 
     @VisibleForTesting
     public AwMinidumpUploaderDelegate(Context context) {
         mContext = context;
         mConnectivityManager =
                 (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
     }
 
     @Override
-    public File createCrashDir() {
+    public File getCacheDir() {
+        // TODO(isherman): This actually results in the directory structure cache/crash/crash.  Is
+        // it worth fixing? We might lose pending crash reports in the nested dir if we do try a fix
+        // here...

[Ilya Sherman, 2017/03/13 03:12:09]

Gustav, WDYT?  (In either case, not a change I'd want to implement in this CL.)

[gsennton, 2017/03/13 17:57:17]

the directory structure is
cache/WebView_Crashes/Crash Reports/

(to fix this we would have to change CrashFileManager to not use "Crash
Reports/" directory - otherwise Monochrome and WebView will be using the same
directory to store its minidumps).
IMO this is not worth fixing.

[Ilya Sherman, 2017/03/14 02:18:55]

Ah, okay, this makes more sense now.  I renamed things a bit to hopefully
clarify the structure.

         return CrashReceiverService.createWebViewCrashDir(mContext);
     }
 
     @Override
     public CrashReportingPermissionManager createCrashReportingPermissionManager() {
         return new CrashReportingPermissionManager() {
             @Override
             public boolean isClientInMetricsSample() {
                 // We will check whether the client is in the metrics sample before
                 // generating a minidump - so if no minidump is generated this code will
@@ skipping 10 matching lines @@
                 // checks only whether the network is WiFi (or ethernet) vs. cellular. Most likely,
                 // Chrome should instead check whether the network is metered, as is done here.
                 NetworkInfo networkInfo = mConnectivityManager.getActiveNetworkInfo();
                 if (networkInfo == null || !networkInfo.isConnected()) return false;
                 return !mConnectivityManager.isActiveNetworkMetered();
             }
             @Override
             public boolean isCrashUploadDisabledByCommandLine() {
                 return false;
             }
-            /**
-             * This method is already represented by isClientInMetricsSample() and
-             * isNetworkAvailableForCrashUploads().
-             */
-            @Override
-            public boolean isMetricsUploadPermitted() {
-                return true;
-            }
             @Override
             public boolean isUsageAndCrashReportingPermittedByUser() {
                 return mPermittedByUser;
             }
             @Override
             public boolean isUploadEnabledForTests() {
                 // Note that CommandLine/CommandLineUtil are not thread safe. They are initialized
                 // on the main thread, but before the current worker thread started - so this thread
                 // will have seen the initialization of the CommandLine.
                 return CommandLine.getInstance().hasSwitch(
@@ skipping 15 matching lines @@
 
     /**
      * Utility method to allow us to test the logic of this class by injecting
      * a test-specific PlatformServiceBridge.
      */
     @VisibleForTesting
     public PlatformServiceBridge createPlatformServiceBridge() {
         return PlatformServiceBridge.getInstance(mContext);
     }
 }