[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.crash;
 
 import android.content.Context;
 import android.net.ConnectivityManager;
 import android.net.NetworkInfo;
 import android.webkit.ValueCallback;
@@ skipping 18 matching lines @@
     private boolean mPermittedByUser = false;
 
     @VisibleForTesting
     public AwMinidumpUploaderDelegate(Context context) {
         mContext = context;
         mConnectivityManager =
                 (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
     }
 
     @Override
-    public File createCrashDir() {
+    public File getCrashParentDir() {
         return CrashReceiverService.createWebViewCrashDir(mContext);
     }
 
     @Override
     public CrashReportingPermissionManager createCrashReportingPermissionManager() {
         return new CrashReportingPermissionManager() {
             @Override
             public boolean isClientInMetricsSample() {
                 // We will check whether the client is in the metrics sample before
                 // generating a minidump - so if no minidump is generated this code will
@@ skipping 15 matching lines @@
             }
             @Override
             public boolean isCrashUploadDisabledByCommandLine() {
                 return false;
             }
             /**
              * This method is already represented by isClientInMetricsSample() and
              * isNetworkAvailableForCrashUploads().
              */
             @Override
             public boolean isMetricsUploadPermitted() {

[gsennton, 2017/03/14 18:17:28]

Why did you add this back?

[Ilya Sherman, 2017/03/15 02:13:34]

Mmm, didn't you ask me to?  Maybe I misunderstood =P  This comment:
https://codereview.chromium.org/2737263006/diff/20001/components/minidump_upl...

[gsennton, 2017/03/15 12:57:43]

Oh, haha, that's right ;).
(I find navigating codereviews a bit of a pain - sometimes I'd like to see a
view of three patch sets instead of two - to be able to match changes from PS1
-> PS2 -> PS3).

                 return true;
             }
             @Override
             public boolean isUsageAndCrashReportingPermittedByUser() {
                 return mPermittedByUser;
             }
             @Override
             public boolean isUploadEnabledForTests() {
                 // Note that CommandLine/CommandLineUtil are not thread safe. They are initialized
                 // on the main thread, but before the current worker thread started - so this thread
                 // will have seen the initialization of the CommandLine.
                 return CommandLine.getInstance().hasSwitch(
                         CommandLineUtil.CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH);
             }
         };
     }
 
     @Override
     public void prepareToUploadMinidumps(final Runnable startUploads) {
         createPlatformServiceBridge().queryMetricsSetting(new ValueCallback<Boolean>() {
             public void onReceiveValue(Boolean enabled) {
                 ThreadUtils.assertOnUiThread();
                 mPermittedByUser = enabled;
                 startUploads.run();
             }
         });
     }
 
+    @Override
+    public void recordUploadSuccess(File minidump) {}
+
+    @Override
+    public void recordUploadFailure(File minidump) {}
+
     /**
      * Utility method to allow us to test the logic of this class by injecting
      * a test-specific PlatformServiceBridge.
      */
     @VisibleForTesting
     public PlatformServiceBridge createPlatformServiceBridge() {
         return PlatformServiceBridge.getInstance(mContext);
     }
 }