[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.crash;
 
 import android.annotation.TargetApi;
 import android.app.Service;
 import android.app.job.JobInfo;
-import android.app.job.JobScheduler;
-import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.os.Binder;
 import android.os.Build;
 import android.os.IBinder;
 import android.os.ParcelFileDescriptor;
 
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.components.minidump_uploader.CrashFileManager;
+import org.chromium.components.minidump_uploader.MinidumpUploadJobService;
 
 import java.io.File;
 import java.io.IOException;
 
 /**
  * Service that is responsible for receiving crash dumps from an application, for upload.
  */
 @TargetApi(Build.VERSION_CODES.LOLLIPOP)
 public class CrashReceiverService extends Service {
     private static final String TAG = "CrashReceiverService";
 
     private static final String WEBVIEW_CRASH_DIR = "WebView_Crashes";
     private static final String WEBVIEW_TMP_CRASH_DIR = "WebView_Crashes_Tmp";
 
+    /**
+     * The job id for uploading minidumps. For more info on this constant, see
+     * https://developer.android.com/reference/android/app/job/JobInfo.Builder.html#JobInfo.Builder(int,%20android.content.ComponentName)
+     */

[gsennton, 2017/03/14 18:17:28]

Maybe add a comment about this having to be different to Chrome's job-ids as
well because of Monochrome?

[Ilya Sherman, 2017/03/15 02:13:34]

Acknowledged.

     private static final int MINIDUMP_UPLOADING_JOB_ID = 42;
-    // Initial back-off time for upload-job, this is set to a fairly high number (30 minutes) to
-    // increase the chance of performing uploads in batches if the initial upload fails.
-    private static final int JOB_BACKOFF_TIME_IN_MS = 1000 * 60 * 30;
-    // Back-off policy for upload-job.
-    private static final int JOB_BACKOFF_POLICY = JobInfo.BACKOFF_POLICY_EXPONENTIAL;
 
     private Object mCopyingLock = new Object();
     private boolean mIsCopying = false;
 
     @Override
     public void onCreate() {
         super.onCreate();
     }
 
     private final ICrashReceiverService.Stub mBinder = new ICrashReceiverService.Stub() {
@@ skipping 46 matching lines @@
                     Log.e(TAG, "Was interrupted when waiting to copy minidumps", e);
                     return false;
                 }
             }
             mIsCopying = true;
             return true;
         }
     }
 
     private void scheduleNewJob() {
-        JobScheduler jobScheduler = (JobScheduler) getSystemService(Context.JOB_SCHEDULER_SERVICE);
-        JobInfo newJob = new JobInfo
-                                 .Builder(MINIDUMP_UPLOADING_JOB_ID /* jobId */,
-                                         new ComponentName(this, AwMinidumpUploadJobService.class))
-                                 .setRequiredNetworkType(JobInfo.NETWORK_TYPE_UNMETERED)
-                                 // Minimum delay when a job is retried (a retry will happen when
-                                 // there are minidumps left after trying to upload all minidumps -
-                                 // this could e.g. happen if we add more minidumps at the same time
-                                 // as uploading old ones).
-                                 .setBackoffCriteria(JOB_BACKOFF_TIME_IN_MS, JOB_BACKOFF_POLICY)
-                                 .build();
-        if (jobScheduler.schedule(newJob) == JobScheduler.RESULT_FAILURE) {
-            throw new RuntimeException("couldn't schedule " + newJob);
-        }
+        JobInfo.Builder builder =
+                new JobInfo
+                        .Builder(MINIDUMP_UPLOADING_JOB_ID,
+                                new ComponentName(this, AwMinidumpUploadJobService.class))
+                        .setRequiredNetworkType(JobInfo.NETWORK_TYPE_UNMETERED);
+        MinidumpUploadJobService.scheduleUpload(this, builder);
     }
 
     /**
      * Copy minidumps from the {@param fileDescriptors} to the directory where WebView stores its
      * minidump files. {@param context} is used to look up the directory in which the files will be
      * saved.
      * @return whether any minidump was copied.
      */
     @VisibleForTesting
     public static boolean copyMinidumps(
@@ skipping 79 matching lines @@
     @VisibleForTesting
     public static File getWebViewTmpCrashDir(Context context) {
         return new File(context.getCacheDir(), WEBVIEW_TMP_CRASH_DIR);
     }
 
     @Override
     public IBinder onBind(Intent intent) {
         return mBinder;
     }
 }