[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.components.minidump_uploader;
 
 import android.content.SharedPreferences;
 import android.support.annotation.IntDef;
 
 import org.chromium.base.ContextUtils;
@@ skipping 95 matching lines @@
                 Log.i(TAG, "Minidump upload skipped due to sampling.  Marking file as skipped for "
                                 + "cleanup to prevent future uploads.");
                 CrashFileManager.markUploadSkipped(mFileToUpload);
                 return UPLOAD_DISABLED_BY_SAMPLING;
             }
 
             if (!mPermManager.isNetworkAvailableForCrashUploads()) {
                 Log.i(TAG, "Minidump cannot currently be uploaded due to network constraints.");
                 return UPLOAD_FAILURE;
             }
-
-            // The above checks should be at least as strict as the requirements for UMA uploads.
-            assert mPermManager.isMetricsUploadPermitted();

[gsennton, 2017/03/13 17:57:17]

Ideally, I would probably remove this in a separate CL, but if this is urgent I
won't block ;)

[Ilya Sherman, 2017/03/14 02:18:55]

Done.

         }
 
         HttpURLConnection connection =
                 mHttpURLConnectionFactory.createHttpURLConnection(CRASH_URL_STRING);
         if (connection == null) {
             return UPLOAD_FAILURE;
         }
 
         FileInputStream minidumpInputStream = null;
         try {
@@ skipping 180 matching lines @@
     // TODO(gayane): Remove this function and unused prefs in M51. crbug.com/555022
     private void removeOutdatedPrefs(SharedPreferences sharedPreferences) {
         SharedPreferences.Editor editor = sharedPreferences.edit();
         editor.remove(PREF_DAY_UPLOAD_COUNT)
                 .remove(PREF_LAST_UPLOAD_DAY)
                 .remove(PREF_LAST_UPLOAD_WEEK)
                 .remove(PREF_WEEK_UPLOAD_SIZE)
                 .apply();
     }
 }