Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2737263004: Ensure chrome watcher exits cleanly on unexpected errors (Closed)

Created:
3 years, 9 months ago by manzagop (departed)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt (UTC plus 2)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure chrome watcher exits cleanly on unexpected errors This mirrors what the installer does. https://cs.chromium.org/chromium/src/chrome/installer/setup/setup_main.cc?l=1367 BUG=699983 Review-Url: https://codereview.chromium.org/2737263004 Cr-Commit-Position: refs/heads/master@{#455814} Committed: https://chromium.googlesource.com/chromium/src/+/208cc84708940c682993ea5feff1003410e329b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/chrome_watcher/chrome_watcher_main.cc View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
manzagop (departed)
Please have a look.
3 years, 9 months ago (2017-03-09 14:59:43 UTC) #4
Sigurður Ásgeirsson
lgtm
3 years, 9 months ago (2017-03-09 17:30:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737263004/1
3 years, 9 months ago (2017-03-09 18:43:32 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:52:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/208cc84708940c682993ea5feff1...

Powered by Google App Engine
This is Rietveld 408576698