Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2737263002: Fixed "characters" typo in message validation when input length is 1 (Closed)

Created:
3 years, 9 months ago by Matt R
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed "characters" typo in message validation when input length is 1 Added IDS_FORM_VALIDATION_TOO_SHORT_PLURAL and updated IDS_FORM_VALIDATION_TOO_SHORT to ensure we don't have grammatical errors showing during "minlength" validation, in case input field length = 1 BUG=686842 Review-Url: https://codereview.chromium.org/2737263002 Cr-Commit-Position: refs/heads/master@{#455823} Committed: https://chromium.googlesource.com/chromium/src/+/9589a8db3dc83b7a06b02de71e28d9213ce1d8f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M content/app/strings/content_strings.grd View 1 chunk +4 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/validationMessage-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebLocalizedString.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Matt R
3 years, 9 months ago (2017-03-09 00:13:35 UTC) #4
tkent
lgtm. minlength attribute value also can be 1. I guess it's very rare, and should ...
3 years, 9 months ago (2017-03-09 00:22:52 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-09 10:41:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737263002/1
3 years, 9 months ago (2017-03-09 19:05:40 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 19:12:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9589a8db3dc83b7a06b02de71e28...

Powered by Google App Engine
This is Rietveld 408576698