Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2737253002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tburkard+watch_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, gavinp+prer_chromium.org, bnc+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (error_page, captive_portal, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2737253002 Cr-Commit-Position: refs/heads/master@{#455624} Committed: https://chromium.googlesource.com/chromium/src/+/2484950e1caae6eda284acc57c5de06cfd8b82fd

Patch Set 1 : Add TEAM/COMPONENT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/captive_portal/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/net/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/prerender/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/captive_portal/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/error_page/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M components/neterror/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-08 23:56:55 UTC) #2
mmenke
On 2017/03/08 23:56:55, ymzhang1 wrote: > Hello, > > We are adding COMPONENT/TEAM information into ...
3 years, 9 months ago (2017-03-09 00:35:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737253002/20001
3 years, 9 months ago (2017-03-09 00:36:32 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:37:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2484950e1caae6eda284acc57c5d...

Powered by Google App Engine
This is Rietveld 408576698