Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2737243003: Remove FrameHost::subFrameCount() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, esprehn, joelhockey
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost::subFrameCount() Remove FrameHost::subFrameCount(), incrementSubframeCount() and decrementSubframeCount(), and redirect all calls to Page. BUG=691794 Review-Url: https://codereview.chromium.org/2737243003 Cr-Commit-Position: refs/heads/master@{#457707} Committed: https://chromium.googlesource.com/chromium/src/+/89a1877418ea6acbc9521be4bb8071356dcb41e3

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
sashab
3 years, 9 months ago (2017-03-17 03:17:16 UTC) #8
sashab
3 years, 9 months ago (2017-03-17 03:48:19 UTC) #10
sashab
3 years, 9 months ago (2017-03-17 04:45:55 UTC) #12
esprehn
lgtm
3 years, 9 months ago (2017-03-17 04:47:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737243003/20001
3 years, 9 months ago (2017-03-17 04:47:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/387914)
3 years, 9 months ago (2017-03-17 04:54:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737243003/40001
3 years, 9 months ago (2017-03-17 05:07:28 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/89a1877418ea6acbc9521be4bb8071356dcb41e3
3 years, 9 months ago (2017-03-17 07:14:56 UTC) #23
haraken
3 years, 9 months ago (2017-03-17 09:39:11 UTC) #24
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698