Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2737223002: Revert of Add failure screenshots and render test images to results detail. (Closed)

Created:
3 years, 9 months ago by mikecase (-- gone --)
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, PEConn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add failure screenshots and render test images to results detail. (patchset #8 id:130001 of https://codereview.chromium.org/2701473003/ ) Reason for revert: Reverting :( this since using find_depot_tools doesnt work on some bots. Will have to find alternative and reland. Original issue's description: > Add failure screenshots and render test images to results detail. > > Review-Url: https://codereview.chromium.org/2701473003 > Cr-Commit-Position: refs/heads/master@{#453039} > Committed: https://chromium.googlesource.com/chromium/src/+/191a06d04a38e8b322c326d42433cbb1f5575025 TBR=yolandyan@chromium.org,hzl@chromium.org,hzl@google.com,jbudorick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2737223002 Cr-Commit-Position: refs/heads/master@{#455639} Committed: https://chromium.googlesource.com/chromium/src/+/85c3c4f9fdb6de0dcda6f8c5e9d460ef09dd292d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -190 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +0 lines, -6 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 7 chunks +3 lines, -121 lines 0 comments Download
D build/android/pylib/utils/google_storage_helper.py View 1 chunk +0 lines, -57 lines 0 comments Download
M build/android/pylib/utils/logdog_helper.py View 4 chunks +4 lines, -3 lines 0 comments Download
A build/android/render_tests/process_render_test_results.py View 1 chunk +214 lines, -0 lines 0 comments Download
A build/android/render_tests/render_webpage.html.jinja2 View 1 chunk +84 lines, -0 lines 0 comments Download
M build/android/test_runner.pydeps View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mikecase (-- gone --)
Created Revert of Add failure screenshots and render test images to results detail.
3 years, 9 months ago (2017-03-08 23:29:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737223002/1
3 years, 9 months ago (2017-03-08 23:30:28 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/379698)
3 years, 9 months ago (2017-03-09 01:11:17 UTC) #5
mikecase (-- gone --)
pls chromeos
3 years, 9 months ago (2017-03-09 01:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737223002/1
3 years, 9 months ago (2017-03-09 01:30:10 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 02:11:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85c3c4f9fdb6de0dcda6f8c5e9d4...

Powered by Google App Engine
This is Rietveld 408576698