Separate VR omnibox and suggestion UI elements.

Separate VR omnibox and suggestion UI elements.

By using separate elements for the omnibox and each suggestion, we fix the
issue of having invisible suggestions intercept the reticle in front of the
content window.

BUG=695898
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2737183002
Cr-Commit-Position: refs/heads/master@{#455871}
Committed: https://chromium.googlesource.com/chromium/src/+/f8f38f56909bd1e53bda5538dee4b1800663de48

[cjgrant, 2017-03-08 19:43:16]

Description was changed from

==========
Separate VR omnibox and suggestion UI elements.

By using separate elements for the omnibox and each suggestion, we fix the
issue of having invisible suggestions intercept the reticle in front of the
content window.

BUG=695898
==========

to

==========
Separate VR omnibox and suggestion UI elements.

By using separate elements for the omnibox and each suggestion, we fix the
issue of having invisible suggestions intercept the reticle in front of the
content window.

BUG=695898
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-03-08 22:07:17]

cjgrant@chromium.org changed reviewers:
+ mthiesse@chromium.org, tiborg@chromium.org

[mthiesse, 2017-03-09 20:02:34]

lgtm

https://codereview.chromium.org/2737183002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2737183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:715: update.setTranslation(0,
elem.sizeY * (i + 0.5), 0);
nit: add a comment explaining 0.5

[cjgrant, 2017-03-09 20:15:16]

https://codereview.chromium.org/2737183002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2737183002/diff/20001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:715: update.setTranslation(0,
elem.sizeY * (i + 0.5), 0);
On 2017/03/09 20:02:34, mthiesse wrote:
> nit: add a comment explaining 0.5

Done.

[cjgrant, 2017-03-09 20:15:19]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-03-09 20:15:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2737183002/#ps40001
(title: "Add an explanatory comment.")

[commit-bot: I haz the power, 2017-03-09 20:15:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 21:39:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489090519555680,
"parent_rev": "f84777c956e16fc211778303d370b853a418e009", "commit_rev":
"f8f38f56909bd1e53bda5538dee4b1800663de48"}

[commit-bot: I haz the power, 2017-03-09 21:40:16]

Description was changed from

==========
Separate VR omnibox and suggestion UI elements.

By using separate elements for the omnibox and each suggestion, we fix the
issue of having invisible suggestions intercept the reticle in front of the
content window.

BUG=695898
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Separate VR omnibox and suggestion UI elements.

By using separate elements for the omnibox and each suggestion, we fix the
issue of having invisible suggestions intercept the reticle in front of the
content window.

BUG=695898
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2737183002
Cr-Commit-Position: refs/heads/master@{#455871}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8f38f56909bd1e53bda5538dee4...
==========

[commit-bot: I haz the power, 2017-03-09 21:40:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f8f38f56909bd1e53bda5538dee4...