Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2737163002: content: Use leaky LazyInstance for maps in render_view_impl.cc (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Use leaky LazyInstance for maps in render_view_impl.cc BUG=698982 Review-Url: https://codereview.chromium.org/2737163002 Cr-Commit-Position: refs/heads/master@{#455572} Committed: https://chromium.googlesource.com/chromium/src/+/8319b23bcb1895fea5a4a308837c100beb42f068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jbroman
These are maps from POD to POD. No need to destroy them at exit.
3 years, 9 months ago (2017-03-08 19:28:01 UTC) #4
Avi (use Gerrit)
LGTM Seems right. Is the trybot failure unrelated?
3 years, 9 months ago (2017-03-08 20:20:11 UTC) #7
jbroman
On 2017/03/08 at 20:20:11, avi wrote: > LGTM > > Seems right. Is the trybot ...
3 years, 9 months ago (2017-03-08 22:24:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737163002/1
3 years, 9 months ago (2017-03-08 22:24:35 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 22:54:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8319b23bcb1895fea5a4a308837c...

Powered by Google App Engine
This is Rietveld 408576698