Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: src/mips64/assembler-mips64.h

Issue 2737143002: MIPS64: Fix declaration for bit() function. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips64/assembler-mips64.h
diff --git a/src/mips64/assembler-mips64.h b/src/mips64/assembler-mips64.h
index 9dd12bbd4335f5c1119e5d108294a4e91d195d20..03eeed9db54dbb915bc28508b1f73428b5cdbd44 100644
--- a/src/mips64/assembler-mips64.h
+++ b/src/mips64/assembler-mips64.h
@@ -132,7 +132,10 @@ struct Register {
DCHECK(is_valid());
return reg_code;
}
- constexpr int bit() const { return DCHECK(is_valid()), 1 << reg_code; }
+ int bit() const {
+ DCHECK(is_valid());
+ return 1 << reg_code;
+ }
// Unfortunately we can't make this private in a struct.
int reg_code;
@@ -196,7 +199,11 @@ struct FPURegister {
DCHECK(is_valid());
return reg_code;
}
- constexpr int bit() const { return DCHECK(is_valid()), 1 << reg_code; }
+
+ int bit() const {
+ DCHECK(is_valid());
+ return 1 << reg_code;
+ }
static FPURegister from_code(int code) {
FPURegister r = {code};
@@ -287,7 +294,10 @@ struct FPUControlRegister {
DCHECK(is_valid());
return reg_code;
}
- constexpr int bit() const { return DCHECK(is_valid()), 1 << reg_code; }
+ int bit() const {
+ DCHECK(is_valid());
+ return 1 << reg_code;
+ }
void setcode(int f) {
reg_code = f;
DCHECK(is_valid());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698