Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2737133002: Replace includes of webrtc/base/task.h and taskparent.h. (Closed)

Created:
3 years, 9 months ago by nisse-chromium (ooo August 14)
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace includes of webrtc/base/task.h and taskparent.h. BUG=webrtc:6424 Review-Url: https://codereview.chromium.org/2737133002 Cr-Commit-Position: refs/heads/master@{#455698} Committed: https://chromium.googlesource.com/chromium/src/+/cf76ebadffe6439b23804274aa1fefc1538feac2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/libjingle_xmpp/xmpp/xmppclient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle_xmpp/xmpp/xmpptask.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nisse-chromium (ooo August 14)
Updating includes, to enable relanding of https://codereview.webrtc.org/2622923002/
3 years, 9 months ago (2017-03-08 11:30:04 UTC) #2
kjellander_chromium
lgtm
3 years, 9 months ago (2017-03-08 12:07:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737133002/1
3 years, 9 months ago (2017-03-08 12:07:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/380847)
3 years, 9 months ago (2017-03-08 12:14:27 UTC) #7
Sergey Ulanov
lgtm
3 years, 9 months ago (2017-03-08 18:46:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737133002/1
3 years, 9 months ago (2017-03-09 08:31:20 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 08:35:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf76ebadffe6439b23804274aa1f...

Powered by Google App Engine
This is Rietveld 408576698